Fixed duplicate code

filipetedim · web-flow · commit e12f62f10574 · 2017-07-05T10:34:56.000+01:00
The proposed "good" way of coding was actually changing a property's name in the developers object.

While one can argue that in this case they could be the same, the point of the example was to show that you can still remove duplicated code that require *different* things.
diff --git a/README.md b/README.md
@@ -439,23 +439,21 @@ function showEmployeeList(employees) {
   employees.forEach((employee) => {
     const expectedSalary = employee.calculateExpectedSalary();
     const experience = employee.getExperience();
+    
+    let data = {
+      expectedSalary,
+      experience
+    };
 
-    let portfolio;
     switch (employee.type) {
       case 'manager':
-        portfolio = employee.getMBAProjects();
+        data.portfolio = employee.getMBAProjects();
         break;
       case 'developer':
-        portfolio = employee.getGithubLink();
+        data.githubLink = employee.getGithubLink();
         break;
     }
 
-    const data = {
-      expectedSalary,
-      experience,
-      portfolio
-    };
-
     render(data);
   });
 }
