usb: gadget: midi2: Fix missing UMP group attributes initialization

tiwai · gregkh · commit 47949bcf66b4 · 2025-09-19T16:35:51.000+02:00
commit 21d8525 upstream. The gadget card driver forgot to call snd_ump_update_group_attrs() after adding FBs, and this leaves the UMP group attributes uninitialized. As a result, -ENODEV error is returned at opening a legacy rawmidi device as an inactive group. This patch adds the missing call to address the behavior above. Fixes: 8b64592 ("usb: gadget: Add support for USB MIDI 2.0 function driver") Cc: stable <stable@kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20250904153932.13589-1-tiwai@suse.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/gadget/function/f_midi2.c b/drivers/usb/gadget/function/f_midi2.c
@@ -1601,6 +1601,7 @@ static int f_midi2_create_card(struct f_midi2 *midi2)
 			strscpy(fb->info.name, ump_fb_name(b),
 				sizeof(fb->info.name));
 		}
+		snd_ump_update_group_attrs(ump);
 	}
 
 	for (i = 0; i < midi2->num_eps; i++) {

Original file line number	Diff line number	Diff line change
`@@ -1601,6 +1601,7 @@ static int f_midi2_create_card(struct f_midi2 *midi2)`
`1601`	`1601`	`strscpy(fb->info.name, ump_fb_name(b),`
`1602`	`1602`	`sizeof(fb->info.name));`
`1603`	`1603`	`}`
	`1604`	`+ snd_ump_update_group_attrs(ump);`
`1604`	`1605`	`}`
`1605`	`1606`
`1606`	`1607`	`for (i = 0; i < midi2->num_eps; i++) {`