net: macb: fix ethernet after resume

claudiubeznea · claudiubeznea · commit e0bc9315ee9b · 2023-01-10T16:00:01.000+02:00
Commit bf0ad18 ("net: macb: Specify PHY PM management done by MAC") signals to PHY layer that the PHY PM management is done by the MAC driver itself. In case this is done the mdio_bus_phy_suspend()/mdio_bus_phy_resume() will return just at its beginning letting the MAC driver to handle the PHY power management. Thus the macb driver needs to re-initialize the PHY device itself when resuming. Otherwise there is poor or missing ping connectivity and performance tests fails at all. This has been tested on my side on SAMA7G5-EK (both interfaces) and SAMA5D27 WLSOM1 EK. Fixes: bf0ad18 ("net: macb: Specify PHY PM management done by MAC") Depends-on: ed01653 ("net: phylink: add helper to initialize phylink's phydev") Tested-by: Cristian Birsan <cristian.birsan@microchip.com> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
@@ -5226,6 +5226,7 @@ static int __maybe_unused macb_resume(struct device *dev)
 	if (!device_may_wakeup(&bp->dev->dev))
 		phy_init(bp->sgmii_phy);
 
+	phylink_init_phydev(bp->phylink);
 	phylink_start(bp->phylink);
 	rtnl_unlock();
 
