Note for self: -O1+ strips out expressions surrounded by assert()

TheAssassin · TheAssassin · commit ce097235f201 · 2018-11-23T18:05:56.000+01:00
diff --git a/src/core/desktopfile/desktopfile.cpp b/src/core/desktopfile/desktopfile.cpp
@@ -173,12 +173,14 @@ namespace linuxdeploy {
                         DesktopFileEntry entry;
 
                         // this should never return false
-                        assert(getEntry(section, key, entry));
+                        auto entryExists = getEntry(section, key, entry);
+                        assert(entryExists);
 
                         ldLog() << LD_WARNING << "Key exists, not modified:" << key << "(current value:" << entry.value() << LD_NO_SPACE << ")" << std::endl;
                         rv = false;
                     } else {
-                        assert(!setEntry(section, std::move(DesktopFileEntry(key, value))));
+                        auto entrySet = setEntry(section, DesktopFileEntry(key, value));
+                        assert(entrySet);
                     }
                 };
 
