Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't remove header files when removing bloat #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knarfS opened this issue Nov 30, 2019 · 4 comments
Closed

Don't remove header files when removing bloat #31

knarfS opened this issue Nov 30, 2019 · 4 comments

Comments

@knarfS
Copy link
Contributor

knarfS commented Nov 30, 2019

Don't remove the header files / the include directory when removing bloat. This way a application can be compiled against these header files.
Maybe add a separate switch (CONDA_SKIP_INCLUDE_CLEANUP) to skip the cleanup of the header files?

@TheAssassin
Copy link
Member

I quickly hacked this cleanup option in last week while trying to build your AppImage. My plan was to provide a way to first run this plugin to create the conda environment with CONDA_SKIP_CLEANUP=1, then do your stuff, then when finally running linuxdeploy allow for e.g., CONDA_CLEANUP_ONLY=1 to run the cleanup routines.

The problem with your suggestion is that there still are header files in the final AppImage, which, after building, just aren't needed.

We could provide both these options, though. Then you get the best of both worlds. What do you think?

@knarfS
Copy link
Contributor Author

knarfS commented Nov 30, 2019

Sounds good to me, though the CONDA_CLEANUP_ONLY=1 would probably be sufficient.

@TheAssassin
Copy link
Member

This kind of issue could be solved even better with linuxdeploy/linuxdeploy#68. Then you could run a "bootstrap" stage first, which would initialize the AppDir and run preliminary tasks (e.g., for the conda plugin, download and install the conda environment), then you could run your own tasks, and then run the remaining tasks.

@TheAssassin
Copy link
Member

Decided to simply go for keeping the headers. I don't think it'll add too much bloat. Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants