fix(eslint-plugin): [no-extra-parens] Fix crash default switch case crash

bradzacher · bradzacher · commit 5ec2b32235ef · 2019-05-13T09:57:59.000-07:00
Fixes typescript-eslint#509
diff --git a/packages/eslint-plugin/src/rules/no-extra-parens.ts b/packages/eslint-plugin/src/rules/no-extra-parens.ts
@@ -200,7 +200,7 @@ export default util.createRule<Options, MessageIds>({
         }
       },
       SwitchCase(node) {
-        if (node.test.type !== AST_NODE_TYPES.TSAsExpression) {
+        if (node.test && node.test.type !== AST_NODE_TYPES.TSAsExpression) {
           return rules.SwitchCase(node);
         }
       },
diff --git a/packages/eslint-plugin/tests/rules/no-extra-parens.test.ts b/packages/eslint-plugin/tests/rules/no-extra-parens.test.ts
@@ -146,7 +146,7 @@ throw 1;
 const x = !(1 as 1);
 const x = (1 as 1)++;
 function *x() { yield (1 as 1); yield 1; }
-switch (foo) { case 1: case (2 as 2): }
+switch (foo) { case 1: case (2 as 2): break; default: break; }
       `,
       options: [
         'all',
diff --git a/packages/typescript-estree/src/ts-estree/ts-estree.ts b/packages/typescript-estree/src/ts-estree/ts-estree.ts
@@ -928,7 +928,7 @@ export interface Super extends BaseNode {
 
 export interface SwitchCase extends BaseNode {
   type: AST_NODE_TYPES.SwitchCase;
-  test: Expression;
+  test: Expression | null;
   consequent: Statement[];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ export default util.createRule<Options, MessageIds>({`
`200`	`200`	`}`
`201`	`201`	`},`
`202`	`202`	`SwitchCase(node) {`
`203`		`- if (node.test.type !== AST_NODE_TYPES.TSAsExpression) {`
	`203`	`+ if (node.test && node.test.type !== AST_NODE_TYPES.TSAsExpression) {`
`204`	`204`	`return rules.SwitchCase(node);`
`205`	`205`	`}`
`206`	`206`	`},`
Original file line number	Diff line number	Diff line change
`@@ -928,7 +928,7 @@ export interface Super extends BaseNode {`
`928`	`928`
`929`	`929`	`export interface SwitchCase extends BaseNode {`
`930`	`930`	`type: AST_NODE_TYPES.SwitchCase;`
`931`		`- test: Expression;`
	`931`	`+ test: Expression \| null;`
`932`	`932`	`consequent: Statement[];`
`933`	`933`	`}`
`934`	`934`