Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f966677

Browse files
authored
Format changes, add contents
1 parent a33906c commit f966677

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

CONTRIBUTING.md

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,21 @@ The repository of the Kubernetes Python client consists of this main repository
2020
### Where to Submit Your Patch
2121

2222
These folders are automatically generated. You will need to submit a patch to the upstream kubernetes repo [kubernetes](https://github.com/kubernetes/kubernetes) or the OpenAPI generator repo [openapi-generator](https://github.com/OpenAPITools/openapi-generator). This contains:
23-
[kubernetes/client](kubernetes/client), [kubernetes/test](kubernetes/test), [kubernetes/docs](kubernetes/docs).
23+
- [kubernetes/client](kubernetes/client)
24+
- [kubernetes/test](kubernetes/test)
25+
- [kubernetes/docs](kubernetes/docs).
2426

2527
These folders contain developer written codes in the main repo and the patches should be submitted here:
26-
[kubernetes/e2e_test](kubernetes/e2e_test), [kubernetes/utils](kubernetes/utils), [examples](examples), [scripts](scripts).
28+
- [kubernetes/e2e_test](kubernetes/e2e_test)
29+
- [kubernetes/utils](kubernetes/utils)
30+
- [examples](examples)
31+
- [scripts](scripts).
2732

2833
The base repo contains developer written codes only. The patches should be sent to the base repo instead. The scope covers these repos and symbolic links in the main repo:
29-
kubernetes/base, kubernetes/config, kubernetes/stream, kubernetes/watch.
34+
- kubernetes/base
35+
- kubernetes/config
36+
- kubernetes/stream
37+
- kubernetes/watch.
3038

3139
### Contributing A Patch
3240

@@ -52,7 +60,7 @@ The symbolic links contained in this repo does not work for Windows operating sy
5260

5361
### Writing Tests
5462

55-
In addition to running the your fix yourself and tell us that your fix works, you can demonstrate that your fix really works by using unit tests. These unit tests are mainly located in three places. You should put your tests into the places that they fit in.
63+
In addition to running the your fix yourself and tell us that your fix works, you can demonstrate that your fix really works by using unit tests and end to end tests. These unit tests are mainly located in three places. You should put your tests into the places that they fit in.
5664

5765
1. [Generated tests](kubernetes/test) by OpenAPI generator: these tests should pass and do not require modification.
5866
2. [End to end tests](kubernetes/e2e_test): these are tests that can only be verified with a live kubernetes server.
@@ -72,3 +80,13 @@ If you write a new end to end (e2e) test, or change behaviors that affect e2e te
7280

7381
3. Check the test results and make corresponding fixes.
7482

83+
## Update the Base Submodule in the Main Repo After Your python-base PR Is Merged
84+
85+
Your contribution of the base repo will not be automatically reflected in the main repo after your PR is merged. Instead, please update the ```base``` submodule in your fork of the main repo as follows:
86+
```bash
87+
$ cd kubernetes/base
88+
$ git fetch origin
89+
$ git checkout origin/master # assuming your change has been merged into the latest python-base MASTER
90+
$ cd ../..
91+
```
92+
You may now add a release note to [CHANGELOG.md](CHANGELOG.md) if needed and then commit and push to your fork. You can now send a PR to this main repo to complete your contribution.

0 commit comments

Comments
 (0)