Fix trailing slash handling in WebSocket URL pathname #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f922d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Contributor
|
thanks for catching this! |
lukasIO
approved these changes
Mar 21, 2025
Merged
svajunas-budrys
pushed a commit
to svajunas-budrys/client-sdk-js
that referenced
this pull request
Jun 17, 2025
Co-authored-by: lukasIO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1439
Previously, the code attempted to remove the trailing slash from urlObj.pathname by setting it to an empty string and then appending "/rtc". However, since URL objects always return "/" for an empty path when a host is present, the existing approach never truly removed the slash. This PR updates the logic to explicitly check if the pathname ends with a slash. If it does, we simply append "rtc". Otherwise, we append "/rtc". This ensures the final path is correctly formed without relying on the pathname being set to an empty string.
References