Add preferred codec for backup codec policy #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 357e58d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
there's a mismatch between the protocol defined backupcodecpolicy and the one redefined in the SDK, that's why the CI is failing |
Contributor
size-limit report 📦
|
lukasIO
reviewed
Mar 26, 2025
src/room/track/options.ts
Outdated
| REGRESSION = 0, | ||
| SIMULCAST = 1, | ||
| // codec regression is preferred, the sfu will try to regress codec if possible but not guaranteed | ||
| PreferRegression = 0, |
Contributor
There was a problem hiding this comment.
not sure if renaming these to camel case is worth it.
- it breaks for users who used the enum previously
- it needs the forced typecast with
as unknownwhich will hide incompatibilities
I think it's better to leave them as uppercase for the reasons above
Contributor
Author
There was a problem hiding this comment.
for 1, I think no user use it now so it is not a problem. if uppercase is ok here, I can revert the naming change.
Merged
svajunas-budrys
pushed a commit
to svajunas-budrys/client-sdk-js
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates livekit/protocol#1002
Also rename the enums according to js naming convention.