Enable dynamic scalability modes for svc dynacast #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4db049b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR enables dynamic scalability modes for svc dynacast by removing the legacy closable spatial layer workaround and adjusting encoding handling, including max bitrate computation.
- Removed commented-out logic and variable "closableSpatial" from the encoding selection process.
- Un-commented and streamlined the use of ScalabilityMode for dynamic settings.
- Added bitrate recalculation logic based on sender encoding properties.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/room/track/LocalVideoTrack.ts | Updated encoding handling by removing legacy closable spatial logic and adjusting ScalabilityMode usage, including bitrate recalculations. |
| .changeset/cyan-pots-warn.md | Introduced a changeset note indicating a patch update related to closable spatial layers for svc encoding. |
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Mar 28, 2025
Merged
svajunas-budrys
pushed a commit
to svajunas-budrys/client-sdk-js
that referenced
this pull request
Jun 17, 2025
cnderrauber
added a commit
that referenced
this pull request
Jun 19, 2025
This reverts commit cf91919.
cnderrauber
added a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.