Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Read files in chunks for sendFile #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Read files in chunks for sendFile #1475

merged 1 commit into from
Apr 8, 2025

Conversation

@lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Apr 8, 2025 •
edited
Loading

  • Reads files in a chunked fashion instead of loading the whole file into memory
  • forwards attributes which was a regression from the previous bytestream PR

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: 56ff1d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from davidzhao April 8, 2025 18:41
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 91.01 KB (+0.04% 🔺)
dist/livekit-client.umd.js 98.74 KB (+0.04% 🔺)

@lukasIO lukasIO changed the title set attributes Read files in chunks for sendFile Apr 8, 2025
@lukasIO lukasIO merged commit 6962f52 into main Apr 8, 2025
6 checks passed
@lukasIO lukasIO deleted the lukas/bytestream-followup branch April 8, 2025 18:43
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
@lukasIO @svajunas-budrys
Read files in chunks for sendFile (livekit#1475)
e69dedb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukasIO @davidzhao