Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@radko93
Copy link
Contributor

@radko93 radko93 commented Apr 10, 2025

fixes #1476

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: 0660dc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO
Copy link
Contributor

lukasIO commented Apr 10, 2025

Thank you!
Overriding URL.pathname instead of manually reconstructing the URL makes a lot of sense to me, but I'd prefer to move this into the appendUrl method.
That way we can also get rid of the searchParams.size check in there which breaks things on RN and electron

@lukasIO
Copy link
Contributor

lukasIO commented Apr 10, 2025

As this is a rather urgent issue I went ahead and modified the PR slightly, thanks for the contribution and the initial fix!

@lukasIO lukasIO changed the title fix: search params for validate calls fix: search params for connect URLs Apr 10, 2025
@lukasIO lukasIO changed the title fix: search params for connect URLs fix: search params compatibility for connect URLs Apr 10, 2025
@lukasIO lukasIO merged commit b366730 into livekit:main Apr 10, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2025
@radko93 radko93 deleted the patch-1 branch April 11, 2025 04:26
@radko93
Copy link
Contributor Author

radko93 commented Apr 11, 2025

Thanks for merging quickly @lukasIO!

svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 SOS!!!! , v2.10.0 not connect

2 participants