Improve device menu auto placement #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c12fe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Ocupe
approved these changes
Apr 7, 2025
Contributor
Ocupe
left a comment
There was a problem hiding this comment.
Not sure if we should remove the resize event listener.
| React.useEffect(() => { | ||
| document.addEventListener<'click'>('click', handleClickOutside); | ||
| window.addEventListener<'resize'>('resize', () => setUpdateRequired(true)); | ||
| // window.addEventListener<'resize'>('resize', () => setUpdateRequired(true)); |
Contributor
There was a problem hiding this comment.
Is this intentional or should it be removed?
Contributor
Author
There was a problem hiding this comment.
the idea is that the responsibility for this is being shifted to the autoUpdate helper of the floating ui lib.
this includes screen resizing and a bunch of other things, see https://floating-ui.com/docs/autoupdate
| return () => { | ||
| document.removeEventListener<'click'>('click', handleClickOutside); | ||
| window.removeEventListener<'resize'>('resize', () => setUpdateRequired(true)); | ||
| // window.removeEventListener<'resize'>('resize', () => setUpdateRequired(true)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.