Fix tests failing on fuchsia clang x86_64 builders (#144655)

Garvit Gupta · web-flow · commit 66d6964a5501 · 2025-06-18T16:50:48.000+05:30
Fuchsia sets CLANG_DEFAULT_UNWINDLIB to libunwind. As a result, when rtlib is set to libgcc and unwindlib is not explicitly specified, tests using Fuchsia as the default platform will fail. To address this, the affected tests are now xfailed This change fixes the following tests introduced in 45ea46c: clang/test/Driver/aarch64-toolchain-extra.c clang/test/Driver/arm-toolchain-extra.c clang/test/Driver/aarch64-toolchain.c clang/test/Driver/arm-toolchain.c
diff --git a/clang/test/Driver/aarch64-toolchain-extra.c b/clang/test/Driver/aarch64-toolchain-extra.c
@@ -3,6 +3,7 @@
 // The tests here are similar to those in aarch64-toolchain.c, however
 // these tests need to create symlinks to test directory trees in order to
 // set up the environment and therefore shell support is required.
+// XFAIL: target={{.*}}-fuchsia{{.*}}
 // REQUIRES: shell
 // UNSUPPORTED: system-windows
 
diff --git a/clang/test/Driver/aarch64-toolchain.c b/clang/test/Driver/aarch64-toolchain.c
@@ -1,3 +1,4 @@
+// XFAIL: target={{.*}}-fuchsia{{.*}}
 // UNSUPPORTED: system-windows
 
 // RUN: %clang -### %s -fuse-ld= \
diff --git a/clang/test/Driver/arm-toolchain-extra.c b/clang/test/Driver/arm-toolchain-extra.c
@@ -3,6 +3,7 @@
 // The tests here are similar to those in arm-toolchain.c, however
 // these tests need to create symlinks to test directory trees in order to
 // set up the environment and therefore shell support is required.
+// XFAIL: target={{.*}}-fuchsia{{.*}}
 // REQUIRES: shell
 // UNSUPPORTED: system-windows
 
diff --git a/clang/test/Driver/arm-toolchain.c b/clang/test/Driver/arm-toolchain.c
@@ -1,3 +1,4 @@
+// XFAIL: target={{.*}}-fuchsia{{.*}}
 // UNSUPPORTED: system-windows
 
 // RUN: %clang -### %s -fuse-ld= \

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// XFAIL: target={{.}}-fuchsia{{.}}`
`1`	`2`	`// UNSUPPORTED: system-windows`
`2`	`3`
`3`	`4`	`// RUN: %clang -### %s -fuse-ld= \`