[AMDGPU] Fix AMDGPULowerKernelAttributes not invalidating analysis (#175256)

jhuber6 · web-flow · commit 9f203509ce7b · 2026-01-09T23:03:15.000Z
Summary: The new PM wasn't using the changed result which triggered failures after #174112
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp b/llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp
@@ -430,12 +430,14 @@ AMDGPULowerKernelAttributesPass::run(Function &F, FunctionAnalysisManager &AM) {
   if (!BasePtr) // ImplicitArgPtr/DispatchPtr not used.
     return PreservedAnalyses::all();
 
+  bool Changed = false;
   for (Instruction &I : instructions(F)) {
     if (CallInst *CI = dyn_cast<CallInst>(&I)) {
       if (CI->getCalledFunction() == BasePtr)
-        processUse(CI, IsV5OrAbove);
+        Changed |= processUse(CI, IsV5OrAbove);
     }
   }
 
-  return PreservedAnalyses::all();
+  return !Changed ? PreservedAnalyses::all()
+                  : PreservedAnalyses::none().preserveSet<CFGAnalyses>();
 }

Original file line number	Diff line number	Diff line change
`@@ -430,12 +430,14 @@ AMDGPULowerKernelAttributesPass::run(Function &F, FunctionAnalysisManager &AM) {`
`430`	`430`	`if (!BasePtr) // ImplicitArgPtr/DispatchPtr not used.`
`431`	`431`	`return PreservedAnalyses::all();`
`432`	`432`
	`433`	`+ bool Changed = false;`
`433`	`434`	`for (Instruction &I : instructions(F)) {`
`434`	`435`	`if (CallInst *CI = dyn_cast<CallInst>(&I)) {`
`435`	`436`	`if (CI->getCalledFunction() == BasePtr)`
`436`		`- processUse(CI, IsV5OrAbove);`
	`437`	`+ Changed \|= processUse(CI, IsV5OrAbove);`
`437`	`438`	`}`
`438`	`439`	`}`
`439`	`440`
`440`		`- return PreservedAnalyses::all();`
	`441`	`+ return !Changed ? PreservedAnalyses::all()`
	`442`	`+ : PreservedAnalyses::none().preserveSet<CFGAnalyses>();`
`441`	`443`	`}`