[lld][ELF] Remove redundant size check in nopInstrFill

boomanaiden154 · web-flow · commit be4dbf5d6459 · 2026-02-07T09:30:20.000-08:00
We checked twice of size is equal to zero. This is not necessary and makes the code a little bit less readable. Reviewers: MaskRay, tmsri Pull Request: #180304
diff --git a/lld/ELF/OutputSections.cpp b/lld/ELF/OutputSections.cpp
@@ -303,8 +303,6 @@ static void nopInstrFill(Ctx &ctx, uint8_t *buf, size_t size) {
   if (size == 0)
     return;
   unsigned i = 0;
-  if (size == 0)
-    return;
   std::vector<std::vector<uint8_t>> nopFiller = *ctx.target->nopInstrs;
   unsigned num = size / nopFiller.back().size();
   for (unsigned c = 0; c < num; ++c) {
