[NFC] [FlowSensitive] [StatusOr] Add test reassigning variable in loop

fmayer · web-flow · commit f7e2e4d2175e · 2026-02-09T10:09:53.000-08:00
Reviewers: jvoung Reviewed By: jvoung Pull Request: #180091
diff --git a/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp b/clang/unittests/Analysis/FlowSensitive/UncheckedStatusOrAccessModelTestFixture.cpp
@@ -1114,6 +1114,55 @@ TEST_P(UncheckedStatusOrAccessModelTest, While_NestedIfWithBinaryCondition) {
       )cc");
 }
 
+TEST_P(UncheckedStatusOrAccessModelTest, While_ReassignValueInLoop) {
+  ExpectDiagnosticsFor(R"cc(
+#include "unchecked_statusor_access_test_defs.h"
+
+    void target() {
+      STATUSOR_INT sor = 3;
+      while (Make<bool>()) sor.value();
+    }
+  )cc");
+  ExpectDiagnosticsFor(R"cc(
+#include "unchecked_statusor_access_test_defs.h"
+
+    void target() {
+      STATUSOR_INT sor = 3;
+      while (Make<bool>()) {
+        sor.value();  // [[unsafe]]
+
+        sor = Make<STATUSOR_INT>();
+      }
+    }
+  )cc");
+  ExpectDiagnosticsFor(R"cc(
+#include "unchecked_statusor_access_test_defs.h"
+
+    void target() {
+      STATUSOR_INT sor = 3;
+      while (Make<bool>()) {
+        sor.value();
+
+        sor = Make<STATUSOR_INT>();
+        if (!sor.ok()) return;
+      }
+    }
+  )cc");
+  ExpectDiagnosticsFor(R"cc(
+#include "unchecked_statusor_access_test_defs.h"
+
+    void target() {
+      STATUSOR_INT sor = 3;
+      while (Make<bool>()) {
+        sor.value();  // [[unsafe]]
+
+        sor = Make<STATUSOR_INT>();
+        if (!sor.ok()) continue;
+      }
+    }
+  )cc");
+}
+
 TEST_P(UncheckedStatusOrAccessModelTest, BuiltinExpect) {
   ExpectDiagnosticsFor(
       R"cc(
