Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add commands to list/enable/disable plugins #134418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 9, 2025
Merged

Add commands to list/enable/disable plugins #134418

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
e240bda
Add commands to list/enable/disable plugins
dmpots Mar 11, 2025
e1c3d46
Apply suggestions from code review
dmpots Apr 4, 2025
681ceaa
Fix formatting and compile error
dmpots Apr 4, 2025
05bc4d4
Fix formatting
dmpots Apr 4, 2025
0f6515f
Move PluginNamespace array into PluginManager
dmpots Apr 11, 2025
779e727
Fix wording in comments and help
dmpots Apr 11, 2025
9e7a695
Remove glob logic for plugin names
dmpots Apr 12, 2025
314cb2d
Get rid of now unused plugin-list option
dmpots Apr 24, 2025
9b41e47
Get rid of unused include
dmpots Apr 24, 2025
0aad1f6
Include plugin info in stats
dmpots Apr 24, 2025
1f863a6
Fix formatting
dmpots Apr 24, 2025
ef976cc
Set success on plugin commands
dmpots Apr 25, 2025
a386406
Add plugin stats test
dmpots Apr 25, 2025
0e7e77f
Clean up formatting
dmpots Apr 25, 2025
3bc5395
[NFC] Refactor - move plugin name matching to PluginManager
dmpots May 31, 2025
4b8dcec
Move json generation into PluginManager
dmpots May 31, 2025
8f1cfdc
Require one argument for enable/disable
dmpots May 31, 2025
99ca1f4
Support json output format for plugin list
dmpots Jun 1, 2025
2633292
Add unit test for MatchPluginName
dmpots Jun 2, 2025
6ada430
Add unit test for PluginManager::GetJSON
dmpots Jun 2, 2025
6260522
Formatting
dmpots Jun 2, 2025
bfcde3d
cleanup uneeded check for argc == 0
dmpots Jun 5, 2025
29aa20d
Use -DAG on json check patterns
dmpots Jun 5, 2025
735dd1f
Add support for enable/disable instrumentation-runtime plugins
dmpots Jun 5, 2025
b31b8a8
Support multiple values in plugin list
dmpots Jun 5, 2025
8b66ff5
Support multiple values in plugin enable
dmpots Jun 6, 2025
aea2cfb
Support multiple values for plugin disable
dmpots Jun 6, 2025
b8d9ad7
Add comment for boolean parameter
dmpots Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup uneeded check for argc == 0
  • Loading branch information
@dmpots
dmpots committed Jun 5, 2025
commit bfcde3db07760af9957718113ffba2000ad120d0
4 changes: 2 additions & 2 deletions lldb/source/Commands/CommandObjectPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ class CommandObjectPluginEnable : public CommandObjectParsed {
result.AppendError("'plugin enable' requires one argument");
return;
}
llvm::StringRef pattern = argc ? command[0].ref() : "";
llvm::StringRef pattern = command[0].ref();
result.SetStatus(eReturnStatusSuccessFinishResult);

int num_matching = SetEnableOnMatchingPlugins(pattern, result, true);
Expand All @@ -275,7 +275,7 @@ class CommandObjectPluginDisable : public CommandObjectParsed {
result.AppendError("'plugin disable' requires one argument");
return;
}
llvm::StringRef pattern = argc ? command[0].ref() : "";
llvm::StringRef pattern = command[0].ref();
result.SetStatus(eReturnStatusSuccessFinishResult);

int num_matching = SetEnableOnMatchingPlugins(pattern, result, false);
Expand Down