From faeb328bfdf2bbddda32f8fef52aefe672ea0daf Mon Sep 17 00:00:00 2001 From: James Newling Date: Wed, 30 Apr 2025 18:37:19 -0700 Subject: [PATCH 1/2] remove default valued constructor args (not used at all) --- mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp index 67e15852dc5ea..5fad0896ddba0 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp @@ -21,7 +21,6 @@ #include "mlir/Transforms/DialectConversion.h" #include "llvm/ADT/ArrayRef.h" #include -#include #include #include @@ -232,7 +231,6 @@ struct LinearizeVectorShuffle final using OpConversionPattern::OpConversionPattern; LinearizeVectorShuffle( const TypeConverter &typeConverter, MLIRContext *context, - unsigned targetVectBitWidth = std::numeric_limits::max(), PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} @@ -292,7 +290,6 @@ struct LinearizeVectorExtract final using OpConversionPattern::OpConversionPattern; LinearizeVectorExtract( const TypeConverter &typeConverter, MLIRContext *context, - unsigned targetVectBitWidth = std::numeric_limits::max(), PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult @@ -341,7 +338,6 @@ struct LinearizeVectorInsert final using OpConversionPattern::OpConversionPattern; LinearizeVectorInsert( const TypeConverter &typeConverter, MLIRContext *context, - unsigned targetVectBitWidth = std::numeric_limits::max(), PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult @@ -410,7 +406,6 @@ struct LinearizeVectorBitCast final using OpConversionPattern::OpConversionPattern; LinearizeVectorBitCast( const TypeConverter &typeConverter, MLIRContext *context, - unsigned targetVectBitWidth = std::numeric_limits::max(), PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult From a30ff1a6e41d21aedd5ab7e416168618e6bb5441 Mon Sep 17 00:00:00 2001 From: James Newling Date: Wed, 30 Apr 2025 19:11:04 -0700 Subject: [PATCH 2/2] format --- .../Vector/Transforms/VectorLinearize.cpp | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp index 5fad0896ddba0..b9fdede535112 100644 --- a/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp +++ b/mlir/lib/Dialect/Vector/Transforms/VectorLinearize.cpp @@ -229,9 +229,8 @@ struct LinearizeVectorExtractStridedSlice final struct LinearizeVectorShuffle final : public OpConversionPattern { using OpConversionPattern::OpConversionPattern; - LinearizeVectorShuffle( - const TypeConverter &typeConverter, MLIRContext *context, - PatternBenefit benefit = 1) + LinearizeVectorShuffle(const TypeConverter &typeConverter, + MLIRContext *context, PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult @@ -288,9 +287,8 @@ struct LinearizeVectorShuffle final struct LinearizeVectorExtract final : public OpConversionPattern { using OpConversionPattern::OpConversionPattern; - LinearizeVectorExtract( - const TypeConverter &typeConverter, MLIRContext *context, - PatternBenefit benefit = 1) + LinearizeVectorExtract(const TypeConverter &typeConverter, + MLIRContext *context, PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult matchAndRewrite(vector::ExtractOp extractOp, OpAdaptor adaptor, @@ -336,9 +334,8 @@ struct LinearizeVectorExtract final struct LinearizeVectorInsert final : public OpConversionPattern { using OpConversionPattern::OpConversionPattern; - LinearizeVectorInsert( - const TypeConverter &typeConverter, MLIRContext *context, - PatternBenefit benefit = 1) + LinearizeVectorInsert(const TypeConverter &typeConverter, + MLIRContext *context, PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult matchAndRewrite(vector::InsertOp insertOp, OpAdaptor adaptor, @@ -404,9 +401,8 @@ struct LinearizeVectorInsert final struct LinearizeVectorBitCast final : public OpConversionPattern { using OpConversionPattern::OpConversionPattern; - LinearizeVectorBitCast( - const TypeConverter &typeConverter, MLIRContext *context, - PatternBenefit benefit = 1) + LinearizeVectorBitCast(const TypeConverter &typeConverter, + MLIRContext *context, PatternBenefit benefit = 1) : OpConversionPattern(typeConverter, context, benefit) {} LogicalResult matchAndRewrite(vector::BitCastOp castOp, OpAdaptor adaptor,