[lldb][windows] remove unneeded DeleteProcThreadAttributeList call (llvm#180579)

charles-zablit · web-flow · commit be711a08b3f4 · 2026-02-09T19:34:43.000+01:00
Remove an unneeded call to `DeleteProcThreadAttributeList`, which is
already done in the `ProcThreadAttributeList` destructor.
diff --git a/lldb/source/Host/windows/ProcessLauncherWindows.cpp b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
@@ -146,9 +146,6 @@ ProcessLauncherWindows::LaunchProcess(const ProcessLaunchInfo &launch_info,
   }
   ProcThreadAttributeList attributelist = std::move(*attributelist_or_err);
 
-  llvm::scope_exit delete_attributelist(
-      [&] { DeleteProcThreadAttributeList(startupinfoex.lpAttributeList); });
-
   std::vector<HANDLE> inherited_handles;
   if (use_pty) {
     if (auto err = attributelist.SetupPseudoConsole(hPC)) {

Original file line number	Diff line number	Diff line change
`@@ -146,9 +146,6 @@ ProcessLauncherWindows::LaunchProcess(const ProcessLaunchInfo &launch_info,`
`146`	`146`	`}`
`147`	`147`	`ProcThreadAttributeList attributelist = std::move(*attributelist_or_err);`
`148`	`148`
`149`		`- llvm::scope_exit delete_attributelist(`
`150`		`- [&] { DeleteProcThreadAttributeList(startupinfoex.lpAttributeList); });`
`151`		`-`
`152`	`149`	`std::vector<HANDLE> inherited_handles;`
`153`	`150`	`if (use_pty) {`
`154`	`151`	`if (auto err = attributelist.SetupPseudoConsole(hPC)) {`