-
-
Notifications
You must be signed in to change notification settings - Fork 0
Enhancement: Declare test code in same directory #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
420ba1a to
aea3253
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
0804a51 to
09ae621
Compare
| /src/ExampleBench.php export-ignore | ||
| /src/ExampleTest.php export-ignore | ||
| /src/Helper.php export-ignore | ||
| /src/ValueCanNotBeBlankTest.php export-ignore | ||
| /src/ValueCanNotBeEmptyTest.php export-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you work on a package and declare test code in the same directory as production code, adding exclusions for test code in .gitattributes is a lot of work.
| "exclude-from-classmap": [ | ||
| "/src/*Bench.php", | ||
| "/src/*Test.php", | ||
| "/src/Helper.php" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in the same directory as production code, managing exclusions for the composer autoloader in composer.json is a lot of work.
| "excludes": [ | ||
| "ExampleBench.php", | ||
| "ExampleTest.php", | ||
| "Helper.php", | ||
| "ValueCanNotBeBlankTest.php", | ||
| "ValueCanNotBeEmptyTest.php" | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in the same directory as production code, managing exclusions for infection/infection in infection.json is a lot of work.
| <exclude> | ||
| <directory suffix="Bench.php">src/</directory> | ||
| <directory suffix="Test.php">src/</directory> | ||
| <file>src/Helper.php</file> | ||
| </exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you declare test code in the same directory as production code, managing exclusions for collecting code coverage with phpunit/phpunit in phpunit.xml is a lot of work.
505a77f to
d8895da
Compare
f7c3d85 to
a30ba58
Compare
a30ba58 to
3fe55ea
Compare
This pull request
src/directory