Normalize tag format in GetSecurityGroupsForVpc response (#12602)

iamramtin · iamramtin · commit 359355d0081e · 2025-05-19T15:09:56.000+02:00
Signed-off-by: Ramtin Mesgari &lt;26694963+iamramtin@users.noreply.github.com&gt;
diff --git a/localstack-core/localstack/services/ec2/provider.py b/localstack-core/localstack/services/ec2/provider.py
@@ -560,7 +560,14 @@ def get_security_groups_for_vpc(
                 GroupName=sg.name,
                 OwnerId=context.account_id,
                 PrimaryVpcId=sg.vpc_id,
-                Tags=[{"Key": k, "Value": v} for k, v in (sg.get_tags() or {}).items()],
+                Tags=[
+                    {
+                        "Key": tag.get("key") or tag.get("Key"),
+                        "Value": tag.get("value") or tag.get("Value"),
+                    }
+                    for tag in (sg.get_tags() or [])
+                    if ("key" in tag or "Key" in tag) and ("value" in tag or "Value" in tag)
+                ],
             )
             for sg in filtered_sgs
         ]
diff --git a/tests/aws/services/ec2/test_ec2.py b/tests/aws/services/ec2/test_ec2.py
@@ -706,8 +706,11 @@ def _create_security_group() -> dict:
     def test_get_security_groups_for_vpc(
         self, snapshot, aws_client, create_vpc, ec2_create_security_group
     ):
+        vpc_name = f"test-vpc-{short_uid()}"
         group_name = f"test-security-group-{short_uid()}"
         group_description = f"Description for {group_name}"
+        tag_key = f"test-key-{short_uid()}"
+        tag_value = f"test-value-{short_uid()}"
 
         # Returned security groups appear to be sorted by the randomly generated GroupId field,
         # so we should sort snapshots by this value to mitigate flakiness for runs against AWS.
@@ -719,10 +722,21 @@ def test_get_security_groups_for_vpc(
         snapshot.add_transformer(snapshot.transform.key_value("VpcId"))
         snapshot.add_transformer(snapshot.transform.key_value("AssociationId"))
         snapshot.add_transformer(snapshot.transform.key_value("DhcpOptionsId"))
+        snapshot.add_transformer(snapshot.transform.key_value("Key"))
+        snapshot.add_transformer(snapshot.transform.key_value("Value"))
 
         # Create VPC for testing
         vpc: dict = create_vpc(
             cidr_block="10.0.0.0/16",
+            tag_specifications=[
+                {
+                    "ResourceType": "vpc",
+                    "Tags": [
+                        {"Key": "Name", "Value": vpc_name},
+                        {"Key": tag_key, "Value": tag_value},
+                    ],
+                }
+            ],
         )
         vpc_id: str = vpc["Vpc"]["VpcId"]
         snapshot.match("create_vpc_response", vpc)
diff --git a/tests/aws/services/ec2/test_ec2.snapshot.json b/tests/aws/services/ec2/test_ec2.snapshot.json
@@ -337,7 +337,7 @@
     }
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc": {
-    "recorded-date": "18-05-2025, 18:08:00",
+    "recorded-date": "19-05-2025, 13:08:48",
     "recorded-content": {
       "create_vpc_response": {
         "Vpc": {
@@ -357,6 +357,16 @@
           "IsDefault": false,
           "OwnerId": "111111111111",
           "State": "pending",
+          "Tags": [
+            {
+              "Key": "<key:1>",
+              "Value": "<value:1>"
+            },
+            {
+              "Key": "<key:2>",
+              "Value": "<value:2>"
+            }
+          ],
           "VpcId": "<vpc-id:1>"
         },
         "ResponseMetadata": {
@@ -369,7 +379,7 @@
           {
             "Description": "<group-name:1> VPC security group",
             "GroupId": "<group-id:1>",
-            "GroupName": "<group-name:1>",
+            "Group<key:1>": "<group-name:1>",
             "OwnerId": "111111111111",
             "PrimaryVpcId": "<vpc-id:1>",
             "Tags": []
@@ -393,15 +403,15 @@
           {
             "Description": "<group-name:1> VPC security group",
             "GroupId": "<group-id:1>",
-            "GroupName": "<group-name:1>",
+            "Group<key:1>": "<group-name:1>",
             "OwnerId": "111111111111",
             "PrimaryVpcId": "<vpc-id:1>",
             "Tags": []
           },
           {
             "Description": "Description for <group-name:2>",
             "GroupId": "<group-id:2>",
-            "GroupName": "<group-name:2>",
+            "Group<key:1>": "<group-name:2>",
             "OwnerId": "111111111111",
             "PrimaryVpcId": "<vpc-id:1>",
             "Tags": []
diff --git a/tests/aws/services/ec2/test_ec2.validation.json b/tests/aws/services/ec2/test_ec2.validation.json
@@ -12,7 +12,7 @@
     "last_validated_date": "2024-06-07T01:11:12+00:00"
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc": {
-    "last_validated_date": "2025-05-18T18:07:59+00:00"
+    "last_validated_date": "2025-05-19T13:09:05+00:00"
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_vcp_peering_difference_regions": {
     "last_validated_date": "2024-06-07T21:28:25+00:00"
