add Terraform test case for Route53 (#3268)

macnev2013 · web-flow · commit ab1d1ea9e39d · 2020-11-25T09:38:43.000+01:00
diff --git a/localstack/plugins.py b/localstack/plugins.py
@@ -37,13 +37,13 @@ def do_register_localstack_plugins():
         from localstack.services.sns import sns_listener
         from localstack.services.sqs import sqs_listener, sqs_starter
         from localstack.services.iam import iam_listener, iam_starter
-        from localstack.services.route53 import route53_listener
+        from localstack.services.route53 import route53_listener, route53_starter
         from localstack.services.sts import sts_starter, sts_listener
         from localstack.services.ses import ses_starter
         from localstack.services.ssm import ssm_listener
         from localstack.services.logs import logs_listener, logs_starter
         from localstack.services.infra import (
-            start_sns, start_route53, start_elasticsearch_service, start_lambda, start_sts, start_ssm,
+            start_sns, start_elasticsearch_service, start_lambda, start_sts, start_ssm,
             start_redshift, start_firehose, start_dynamodbstreams, start_acm
         )
         from localstack.services.events import events_listener, events_starter
@@ -140,7 +140,7 @@ def do_register_localstack_plugins():
 
         register_plugin(Plugin(
             'route53',
-            start=start_route53,
+            start=route53_starter.start_route53,
             listener=route53_listener.UPDATE_ROUTE53))
 
         register_plugin(Plugin(
diff --git a/localstack/services/infra.py b/localstack/services/infra.py
@@ -101,12 +101,6 @@ def start_redshift(port=None, asynchronous=False):
     return start_moto_server('redshift', port, name='Redshift', asynchronous=asynchronous)
 
 
-def start_route53(port=None, asynchronous=False, update_listener=None):
-    port = port or config.PORT_ROUTE53
-    return start_moto_server('route53', port, name='Route53', asynchronous=asynchronous,
-        update_listener=update_listener)
-
-
 def start_acm(port=None, asynchronous=False):
     port = port or config.PORT_ACM
     return start_moto_server('acm', port, name='ACM', asynchronous=asynchronous)
diff --git a/localstack/services/route53/route53_starter.py b/localstack/services/route53/route53_starter.py
@@ -0,0 +1,10 @@
+from localstack import config
+from localstack.services.infra import start_moto_server
+
+
+def start_route53(port=None, asynchronous=False, update_listener=None):
+    port = port or config.PORT_ROUTE53
+    return start_moto_server(
+        'route53', port, name='Route53',
+        asynchronous=asynchronous, update_listener=update_listener
+    )
diff --git a/tests/integration/terraform/provider.tf b/tests/integration/terraform/provider.tf
@@ -13,5 +13,6 @@ provider "aws" {
     lambda = "http://localhost:4566"
     iam    = "http://localhost:4566"
     apigateway = "http://localhost:4566"
+    route53 = "http://localhost:4566"
   }
 }
diff --git a/tests/integration/terraform/route53.tf b/tests/integration/terraform/route53.tf
@@ -0,0 +1,14 @@
+resource "aws_route53_zone" "tf_route53_zone" {
+  name = "test.example.com"
+  tags = {
+    name = "tf-route53-zone"
+  }
+}
+
+resource "aws_route53_record" "tf_route53_record" {
+  zone_id = aws_route53_zone.tf_route53_zone.zone_id
+  name    = "test.example.com"
+  type    = "A"
+  ttl     = "1"
+  records = ["1.1.1.1"]
+}
diff --git a/tests/integration/test_terraform.py b/tests/integration/test_terraform.py
@@ -90,3 +90,12 @@ def test_apigateway(self):
         self.assertEqual(len(res2[0]['resourceMethods']), 2)
         self.assertEqual(res2[0]['resourceMethods']['GET']['methodIntegration']['type'], 'AWS_PROXY')
         self.assertTrue(res2[0]['resourceMethods']['GET']['methodIntegration']['uri'])
+
+    def test_route53(self):
+        route53 = aws_stack.connect_to_service('route53')
+
+        response = route53.create_hosted_zone(Name='zone123', CallerReference='ref123')
+        self.assertEqual(201, response['ResponseMetadata']['HTTPStatusCode'])
+
+        response = route53.get_change(Id='string')
+        self.assertEqual(200, response['ResponseMetadata']['HTTPStatusCode'])

Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@ provider "aws" {`
`13`	`13`	`lambda = "http://localhost:4566"`
`14`	`14`	`iam = "http://localhost:4566"`
`15`	`15`	`apigateway = "http://localhost:4566"`
	`16`	`+ route53 = "http://localhost:4566"`
`16`	`17`	`}`
`17`	`18`	`}`