Ensure tests work correctly with the updated ec2_create_security_group fixture (#12602)

iamramtin · iamramtin · commit ae55ba2d3588 · 2025-05-14T22:58:13.000+02:00
Signed-off-by: Ramtin Mesgari &lt;26694963+iamramtin@users.noreply.github.com&gt;
diff --git a/tests/aws/services/ec2/test_ec2.py b/tests/aws/services/ec2/test_ec2.py
@@ -734,6 +734,7 @@ def test_get_security_groups_for_vpc(
             GroupName="test-security-group-1",
             Description="Test Security Group 1 Description",
             VpcId=vpc_id,
+            ports=[22]
         )
         sg1_id = sg1["GroupId"]
         snapshot.match("create_security_group_1", sg1)
@@ -742,6 +743,7 @@ def test_get_security_groups_for_vpc(
             GroupName="test-security-group-2",
             Description="Test Security Group 2 Description",
             VpcId=vpc_id,
+            ports=[22]
         )
         sg2_id = sg2["GroupId"]
         snapshot.match("create_security_group_2", sg2)
@@ -756,6 +758,7 @@ def test_get_security_groups_for_vpc(
             GroupName="test-security-group-3",
             Description="Test Security Group 3 Description",
             VpcId=default_vpc_id,
+            ports=[22]
         )
         sg3_id = sg3["GroupId"]
         snapshot.match("create_security_group_3", sg3)
@@ -769,11 +772,6 @@ def test_get_security_groups_for_vpc(
         assert sg2_id in vpc_sg_ids
         assert sg3_id not in vpc_sg_ids
 
-        cleanups.append(lambda: aws_client.ec2.delete_vpc(VpcId=vpc_id))
-        cleanups.append(lambda: aws_client.ec2.delete_security_group(GroupId=sg1_id))
-        cleanups.append(lambda: aws_client.ec2.delete_security_group(GroupId=sg2_id))
-        cleanups.append(lambda: aws_client.ec2.delete_security_group(GroupId=sg3_id))
-
 
 @markers.snapshot.skip_snapshot_verify(
     # Moto and LS do not return the ClientToken
diff --git a/tests/aws/services/ec2/test_ec2.snapshot.json b/tests/aws/services/ec2/test_ec2.snapshot.json
@@ -337,7 +337,7 @@
     }
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc": {
-    "recorded-date": "14-05-2025, 20:05:26",
+    "recorded-date": "14-05-2025, 20:57:48",
     "recorded-content": {
       "create_vpc": {
         "vpc-id": "<vpc-id:1>"
@@ -369,17 +369,17 @@
       "get_security_groups_for_vpc": {
         "SecurityGroupForVpcs": [
           {
-            "Description": "Test Security Group 2 Description",
-            "GroupId": "<group-id:2>",
-            "GroupName": "test-security-group-2",
+            "Description": "default VPC security group",
+            "GroupId": "<group-id:4>",
+            "GroupName": "default",
             "OwnerId": "111111111111",
             "PrimaryVpcId": "<vpc-id:1>",
             "Tags": []
           },
           {
-            "Description": "default VPC security group",
-            "GroupId": "<group-id:4>",
-            "GroupName": "default",
+            "Description": "Test Security Group 2 Description",
+            "GroupId": "<group-id:2>",
+            "GroupName": "test-security-group-2",
             "OwnerId": "111111111111",
             "PrimaryVpcId": "<vpc-id:1>",
             "Tags": []
@@ -399,9 +399,5 @@
         }
       }
     }
-  },
-  "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc_invalid_inputs": {
-    "recorded-date": "14-05-2025, 20:07:05",
-    "recorded-content": {}
   }
 }
diff --git a/tests/aws/services/ec2/test_ec2.validation.json b/tests/aws/services/ec2/test_ec2.validation.json
@@ -12,7 +12,7 @@
     "last_validated_date": "2024-06-07T01:11:12+00:00"
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc": {
-    "last_validated_date": "2025-05-14T20:05:19+00:00"
+    "last_validated_date": "2025-05-14T20:57:45+00:00"
   },
   "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_vcp_peering_difference_regions": {
     "last_validated_date": "2024-06-07T21:28:25+00:00"

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@`
`337`	`337`	`}`
`338`	`338`	`},`
`339`	`339`	`"tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc": {`
`340`		`- "recorded-date": "14-05-2025, 20:05:26",`
	`340`	`+ "recorded-date": "14-05-2025, 20:57:48",`
`341`	`341`	`"recorded-content": {`
`342`	`342`	`"create_vpc": {`
`343`	`343`	`"vpc-id": "<vpc-id:1>"`
`@@ -369,17 +369,17 @@`
`369`	`369`	`"get_security_groups_for_vpc": {`
`370`	`370`	`"SecurityGroupForVpcs": [`
`371`	`371`	`{`
`372`		`- "Description": "Test Security Group 2 Description",`
`373`		`- "GroupId": "<group-id:2>",`
`374`		`- "GroupName": "test-security-group-2",`
	`372`	`+ "Description": "default VPC security group",`
	`373`	`+ "GroupId": "<group-id:4>",`
	`374`	`+ "GroupName": "default",`
`375`	`375`	`"OwnerId": "111111111111",`
`376`	`376`	`"PrimaryVpcId": "<vpc-id:1>",`
`377`	`377`	`"Tags": []`
`378`	`378`	`},`
`379`	`379`	`{`
`380`		`- "Description": "default VPC security group",`
`381`		`- "GroupId": "<group-id:4>",`
`382`		`- "GroupName": "default",`
	`380`	`+ "Description": "Test Security Group 2 Description",`
	`381`	`+ "GroupId": "<group-id:2>",`
	`382`	`+ "GroupName": "test-security-group-2",`
`383`	`383`	`"OwnerId": "111111111111",`
`384`	`384`	`"PrimaryVpcId": "<vpc-id:1>",`
`385`	`385`	`"Tags": []`
`@@ -399,9 +399,5 @@`
`399`	`399`	`}`
`400`	`400`	`}`
`401`	`401`	`}`
`402`		`- },`
`403`		`- "tests/aws/services/ec2/test_ec2.py::TestEc2Integrations::test_get_security_groups_for_vpc_invalid_inputs": {`
`404`		`- "recorded-date": "14-05-2025, 20:07:05",`
`405`		`- "recorded-content": {}`
`406`	`402`	`}`
`407`	`403`	`}`