Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CFNv2: implement create_stack #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Jun 20, 2025

Motivation

A major missing piece of the V2 provider is CreateStack.

Changes

  • Update the stack object to only reference the change set where relevant
  • Introduce a better way of raising the stack not found error (rather than the old stack_not_found_error factory function)
  • Make finding stacks return an optional stack (since the delete function ignores missing stacks
  • Use find_stack_v2 in find_change_set_v2
  • Add create_change_set method
    • this creates a "hidden" change set (which is not kept in the store), but otherwise proceeds the same as if the user calls create_change_set then execute_change_set in a row
  • Skip tests that were failing for the wrong reason (i.e. they expected a validation error, but got a 500 error as the v1 provider's create_stack method was called and could not find the stack)
  • Skip one test specifically about creating stacks

@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Jun 20, 2025
Copy link

github-actions bot commented Jun 20, 2025

Test Results - Preflight, Unit

21 635 tests  ±0   19 978 ✅ ±0   6m 19s ⏱️ +5s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7dffb23. ± Comparison against base commit 6348947.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7dffb23. ± Comparison against base commit 6348947.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 45m 56s ⏱️ + 2m 31s
4 890 tests ±0  4 116 ✅ ±0  774 💤 ±0  0 ❌ ±0 
4 892 runs  ±0  4 116 ✅ ±0  776 💤 ±0  0 ❌ ±0 

Results for commit 7dffb23. ± Comparison against base commit 6348947.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 1s ⏱️
5 247 tests 4 321 ✅ 926 💤 0 ❌
5 253 runs  4 321 ✅ 932 💤 0 ❌

Results for commit 7dffb23.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 20, 2025

Test Results - Alternative Providers

988 tests   621 ✅  34m 29s ⏱️
  4 suites  367 💤
  4 files      0 ❌

Results for commit 7dffb23.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/v2/implement-create-stack branch from b99a65c to 2455e80 Compare June 20, 2025 20:43
@simonrw simonrw force-pushed the cfn/v2/implement-create-stack branch from 2455e80 to 7dffb23 Compare June 20, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:cloudformation AWS CloudFormation semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant