-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CFNv2: implement create_stack #12779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simonrw
wants to merge
3
commits into
master
Choose a base branch
from
cfn/v2/implement-create-stack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 22m 1s ⏱️ Results for commit 7dffb23. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers988 tests 621 ✅ 34m 29s ⏱️ Results for commit 7dffb23. ♻️ This comment has been updated with latest results. |
b99a65c
to
2455e80
Compare
2455e80
to
7dffb23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aws:cloudformation
AWS CloudFormation
semver: minor
Non-breaking changes which can be included in minor releases, but not in patch releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A major missing piece of the V2 provider is
CreateStack
.Changes
stack_not_found_error
factory function)find_stack_v2
infind_change_set_v2
create_change_set
methodcreate_change_set
thenexecute_change_set
in a rowcreate_stack
method was called and could not find the stack)