Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 11, 2025

Motivation

Our skip_if_v1_provider is not named well:

  1. it mentions v1 rather than legacy
  2. it says provider rather than engine

Also there is no longer a need to add a message

Changes

  • reword decorator
  • remove required message argument

@simonrw simonrw added aws:cloudformation AWS CloudFormation area: asf semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted skip-docs Pull request does not require documentation changes labels Sep 11, 2025
@simonrw simonrw added this to the Playground milestone Sep 11, 2025
Copy link

Test Results - Preflight, Unit

22 124 tests   20 386 ✅  6m 40s ⏱️
     1 suites   1 738 💤
     1 files         0 ❌

Results for commit b94416c.

Copy link

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 7s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit b94416c.

Copy link

LocalStack Community integration with Pro

  2 files    2 suites   35m 6s ⏱️
558 tests 443 ✅ 115 💤 0 ❌
560 runs  443 ✅ 117 💤 0 ❌

Results for commit b94416c.

Copy link

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   47m 4s ⏱️
582 tests 468 ✅ 114 💤 0 ❌
588 runs  468 ✅ 120 💤 0 ❌

Results for commit b94416c.

@simonrw simonrw removed the area: asf label Sep 11, 2025
@simonrw simonrw modified the milestones: Playground, 4.9 Sep 11, 2025
Copy link

Test Results - Alternative Providers

557 tests   328 ✅  23m 38s ⏱️
  1 suites  229 💤
  1 files      0 ❌

Results for commit b94416c.

@simonrw simonrw marked this pull request as ready for review September 11, 2025 14:18
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

@simonrw simonrw removed the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Sep 11, 2025
@simonrw simonrw marked this pull request as draft September 11, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants