check for Infinity in rangebreak l2p

archmoj · archmoj · commit 063632d08e21 · 2020-03-28T22:19:14.000-04:00
diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js
@@ -222,7 +222,10 @@ module.exports = function setConvert(ax, fullLayout) {
                     break;
                 }
             }
-            return _l2p(v, (isY ? -1 : 1) * ax._m2, ax._B[q]);
+            var b2 = ax._B[q] || 0;
+            if(!isFinite(b2)) return 0; // avoid NaN translate e.g. in positionLabels if one keep zooming exactly into a break
+
+            return _l2p(v, (isY ? -1 : 1) * ax._m2, b2);
         };
 
         p2l = function(px) {
@@ -242,8 +245,8 @@ module.exports = function setConvert(ax, fullLayout) {
                 if(pos < brk.pmin) break;
                 if(pos > brk.pmax) q = nextI;
             }
-
-            return _p2l(px, (isY ? -1 : 1) * ax._m2, ax._B[q]);
+            var b2 = ax._B[q];
+            return _p2l(px, (isY ? -1 : 1) * ax._m2, b2);
         };
     }
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,10 @@ module.exports = function setConvert(ax, fullLayout) {`
`222`	`222`	`break;`
`223`	`223`	`}`
`224`	`224`	`}`
`225`		`- return _l2p(v, (isY ? -1 : 1) * ax._m2, ax._B[q]);`
	`225`	`+ var b2 = ax._B[q] \|\| 0;`
	`226`	`+ if(!isFinite(b2)) return 0; // avoid NaN translate e.g. in positionLabels if one keep zooming exactly into a break`
	`227`	`+`
	`228`	`+ return _l2p(v, (isY ? -1 : 1) * ax._m2, b2);`
`226`	`229`	`};`
`227`	`230`
`228`	`231`	`p2l = function(px) {`
`@@ -242,8 +245,8 @@ module.exports = function setConvert(ax, fullLayout) {`
`242`	`245`	`if(pos < brk.pmin) break;`
`243`	`246`	`if(pos > brk.pmax) q = nextI;`
`244`	`247`	`}`
`245`		`-`
`246`		`- return _p2l(px, (isY ? -1 : 1) * ax._m2, ax._B[q]);`
	`248`	`+ var b2 = ax._B[q];`
	`249`	`+ return _p2l(px, (isY ? -1 : 1) * ax._m2, b2);`
`247`	`250`	`};`
`248`	`251`	`}`
`249`	`252`