add order by behaviour with array similar to get method #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Mohit21GoJs! Could you rebase this PR without the package-lock.json update? |
Updated @jdalton , please review. |
jdalton
reviewed
Aug 30, 2019
.internal/baseOrderBy.js
Outdated
| return (value) => baseGet(value, iteratee) | ||
| } | ||
| return iteratee | ||
| }) : [(value) => value] |
There was a problem hiding this comment.
We have a method called identity that can me used for (value) => value.
There was a problem hiding this comment.
@jdalton the existing identity was defined in ../test/util.js, hence i defined a identity function in this file as there is no other util file, let me know if it makes sense.
|
Ah cool. Thanks @Mohit21GoJs! |
|
@jdalton Shall we backport this to |
|
@falsyvalues That would be a good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #4438