Merge pull request #517 from foxhlchen/pr-empty-filename

wilx · web-flow · commit 06d9b65b518f · 2021-08-15T13:21:09.000+02:00
`filename` should not be empty for TimeBasedRollingFileAppender
diff --git a/src/fileappender.cxx b/src/fileappender.cxx
@@ -1356,7 +1356,10 @@ void
 TimeBasedRollingFileAppender::open(std::ios_base::openmode mode)
 {
     scheduledFilename = helpers::getFormattedTime(filenamePattern, helpers::now(), false);
-    tstring currentFilename = filename.empty() ? scheduledFilename : filename;
+    if (filename.empty())
+        filename = scheduledFilename;
+
+    tstring currentFilename = filename;
 
     if (createDirs)
         internal::make_dirs (currentFilename);
@@ -1401,7 +1404,7 @@ TimeBasedRollingFileAppender::rollover(bool alreadyLocked)
     // should remain unchanged on a close
     out.clear();
 
-    if (! filename.empty())
+    if (filename != scheduledFilename)
     {
         helpers::LogLog & loglog = helpers::getLogLog();
         long ret;
