[clang-tidy] Match references

neheb · wilx · commit 10a6246b9e30 · 2019-09-07T13:28:26.000+02:00
Found with performance-unnecessary-copy-initialization (cherry picked from commit f69468d) Signed-off-by: Vaclav Haisman <vhaisman@gmail.com>
diff --git a/src/clfsappender.cxx b/src/clfsappender.cxx
@@ -93,7 +93,7 @@ CLFSAppender::CLFSAppender (helpers::Properties const & props)
     : Appender (props)
     , data (new Data)
 {
-    tstring logname = props.getProperty (LOG4CPLUS_TEXT ("LogName"));
+    const tstring& logname = props.getProperty (LOG4CPLUS_TEXT ("LogName"));
 
     unsigned long logsize = CLFS_APPENDER_INITIAL_LOG_SIZE;
     props.getULong (logsize, LOG4CPLUS_TEXT ("LogSize"));
diff --git a/src/filter.cxx b/src/filter.cxx
@@ -341,7 +341,7 @@ FilterResult MDCMatchFilter::decide(const InternalLoggingEvent& event) const
     if(neutralOnEmpty && (mdcKeyToMatch.empty() || mdcValueToMatch.empty()))
         return NEUTRAL;
 
-    const tstring mdcStr = event.getMDC(mdcKeyToMatch);
+    const tstring& mdcStr = event.getMDC(mdcKeyToMatch);
 
     if(neutralOnEmpty && mdcStr.empty())
         return NEUTRAL;

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ CLFSAppender::CLFSAppender (helpers::Properties const & props)`
`93`	`93`	`: Appender (props)`
`94`	`94`	`, data (new Data)`
`95`	`95`	`{`
`96`		`- tstring logname = props.getProperty (LOG4CPLUS_TEXT ("LogName"));`
	`96`	`+ const tstring& logname = props.getProperty (LOG4CPLUS_TEXT ("LogName"));`
`97`	`97`
`98`	`98`	`unsigned long logsize = CLFS_APPENDER_INITIAL_LOG_SIZE;`
`99`	`99`	`props.getULong (logsize, LOG4CPLUS_TEXT ("LogSize"));`