Merge pull request #1401 from MamfTheKramf/http-response-chaining

lamweili · web-flow · commit bc59c87050e7 · 2024-04-05T13:55:29.000+08:00
fix: enable method chaining for after writeHead
diff --git a/lib/connect-logger.js b/lib/connect-logger.js
@@ -273,6 +273,7 @@ module.exports = function getLogger(logger4js, options) {
 
         res.__statusCode = code;
         res.__headers = headers || {};
+        return res;
       };
 
       // hook on end request to emit the log entry of the HTTP request.
diff --git a/test/tap/connect-context-test.js b/test/tap/connect-context-test.js
@@ -58,6 +58,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }
 
diff --git a/test/tap/connect-logger-test.js b/test/tap/connect-logger-test.js
@@ -58,6 +58,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }
 
@@ -87,8 +88,7 @@ function request(
     next = () => {};
   }
   cl(req, res, next);
-  res.writeHead(code, resHeaders);
-  res.end('chunk', 'encoding');
+  res.writeHead(code, resHeaders).end('chunk', 'encoding');
 }
 
 test('log4js connect logger', (batch) => {
diff --git a/test/tap/connect-nolog-test.js b/test/tap/connect-nolog-test.js
@@ -49,6 +49,7 @@ class MockResponse extends EE {
 
   writeHead(code /* , headers */) {
     this.statusCode = code;
+    return this;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ class MockResponse extends EE {`
`58`	`58`
`59`	`59`	`writeHead(code /* , headers */) {`
`60`	`60`	`this.statusCode = code;`
	`61`	`+ return this;`
`61`	`62`	`}`
`62`	`63`	`}`
`63`	`64`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ class MockResponse extends EE {`
`49`	`49`
`50`	`50`	`writeHead(code /* , headers */) {`
`51`	`51`	`this.statusCode = code;`
	`52`	`+ return this;`
`52`	`53`	`}`
`53`	`54`	`}`
`54`	`55`