Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[IMPROVEMENT] detailed log for the reason of node controller deleting backing image copiesΒ #12584

Description

@COLDTURNIP

Is your feature request related to a problem? Please describe (πŸ‘ if you like this request)

To current design, when node controller decide to delete a backing image copy from a disk, there is not corresponding logs for the reason of deletion. When it wrongly deletes a copy, the BI spec is already updated and there is nothing to trace the deleted copy.

Describe the solution you'd like

Node controller need to at lease write the log down the detail of the decision of image copy deletion.

  • What is the required minimum number of retained copies?
  • How many copies are there before or after this deletion?
  • How many failed copies are counted at this moment?
  • What is the state of this deleting copy?

These information helps us to track the image copy history.

Describe alternatives you've considered

BI controller passively handles the copy deletion event with the BI CR spec change. Only the Node controller knows the reason of the spec change.

In the other hand, to current design, we don't have dedicate CR to track state of BI copies. All the events are recorded in BI scope, not for an individual copy.

Additional context

No response

Metadata

Metadata

Labels

area/backing-imageBacking image relatedbackport/1.11.1Require to backport to 1.11.1 release branchkind/improvementRequest for improvement of existing functionrequire/auto-e2e-testRequire adding/updating auto e2e test cases if they can be automatedrequire/manual-test-planRequire adding/updating manual test cases if they can't be automated
No fields configured for Improvement.

Projects

Status
Closed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions