Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[IMPROVEMENT] CRD enum values #9718

Description

@ah8ad3

If you execute kubectl explain lhb.spec you will see

  backupMode	<string>
  enum: full, incremental, ""
    The backup mode of this backup.
    Can be "full" or "incremental"

As it states possible values are full, incremental but in CRD it also take "" (empty string), we should either update the document there or remove "" from CRD.

Describe the solution you'd like

Update here document or CRD here:
https://github.com/search?q=repo%3Alonghorn%2Flonghorn%20%22The%20backup%20mode%20of%20this%20backup%22&type=code

Additional context

Compare it with kubectl explain pod.spec.preemptionPolicy

KIND:       Pod
VERSION:    v1

FIELD: preemptionPolicy <string>
ENUM:
    Never
    PreemptLowerPriority

DESCRIPTION:
    PreemptionPolicy is the Policy for preempting pods with lower priority. One
    of Never, PreemptLowerPriority. Defaults to PreemptLowerPriority if unset.
    
    Possible enum values:
     - `"Never"` means that pod never preempts other pods with lower priority.
     - `"PreemptLowerPriority"` means that pod can preempt other pods with lower
    priority.

Metadata

Metadata

Labels

Type

No type
No fields configured for issues without a type.

Projects

Status
Resolved
Status
Closed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions