do not enable smooth shading with bad epsilon by default

archmoj · archmoj · commit 874c3adedfec · 2019-10-27T20:33:40.000-04:00
diff --git a/src/traces/isosurface/attributes.js b/src/traces/isosurface/attributes.js
@@ -249,8 +249,5 @@ colorScaleAttrs('', {
     hoverinfo: extendFlat({}, baseAttrs.hoverinfo)
 }), 'calc', 'nested');
 
-// required defaults to speed up surface normal calculations
-attrs.flatshading.dflt = true; attrs.lighting.facenormalsepsilon.dflt = 0;
-
 attrs.x.editType = attrs.y.editType = attrs.z.editType = attrs.value.editType = 'calc+clearAxisTypes';
 attrs.transforms = undefined;
diff --git a/src/traces/mesh3d/attributes.js b/src/traces/mesh3d/attributes.js
@@ -191,7 +191,7 @@ colorScaleAttrs('', {
     flatshading: {
         valType: 'boolean',
         role: 'style',
-        dflt: false,
+        dflt: true,
         editType: 'calc',
         description: [
             'Determines whether or not normal smoothing is applied to the meshes,',
@@ -215,18 +215,18 @@ colorScaleAttrs('', {
         vertexnormalsepsilon: {
             valType: 'number',
             role: 'style',
-            min: 0.00,
+            min: 0,
             max: 1,
-            dflt: 1e-12, // otherwise finely tessellated things eg. the brain will have no specular light reflection
+            dflt: 0,
             editType: 'calc',
             description: 'Epsilon for vertex normals calculation avoids math issues arising from degenerate geometry.'
         },
         facenormalsepsilon: {
             valType: 'number',
             role: 'style',
-            min: 0.00,
+            min: 0,
             max: 1,
-            dflt: 1e-6, // even the brain model doesn't appear to need finer than this
+            dflt: 0,
             editType: 'calc',
             description: 'Epsilon for face normals calculation avoids math issues arising from degenerate geometry.'
         },
