Merge pull request laravel#724 from AndreasHeiberg/bug-sync-uniquenesss-constraint-conflicts

taylorotwell · taylorotwell · commit 6331b3a22318 · 2013-03-27T11:42:31.000-07:00
Detach before attach to prevent uniqueness constraint conflicts
diff --git a/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php b/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -398,8 +398,6 @@ public function sync(array $ids)
 
 		$records = $this->formatSyncList($ids);
 
-		$this->attachNew($records, $current);
-
 		$detach = array_diff($current, array_keys($records));
 
 		// Next, we will take the differences of the currents and given IDs and detach
@@ -409,6 +407,8 @@ public function sync(array $ids)
 		{
 			$this->detach($detach);
 		}
+
+		$this->attachNew($records, $current);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -398,8 +398,6 @@ public function sync(array $ids)`
`398`	`398`
`399`	`399`	`$records = $this->formatSyncList($ids);`
`400`	`400`
`401`		`- $this->attachNew($records, $current);`
`402`		`-`
`403`	`401`	`$detach = array_diff($current, array_keys($records));`
`404`	`402`
`405`	`403`	`// Next, we will take the differences of the currents and given IDs and detach`
`@@ -409,6 +407,8 @@ public function sync(array $ids)`
`409`	`407`	`{`
`410`	`408`	`$this->detach($detach);`
`411`	`409`	`}`
	`410`	`+`
	`411`	`+ $this->attachNew($records, $current);`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`/**`