Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 7c5a68c

Browse files
committed
Refactoring
Avoid socket connection in destructor Replace IF_ATOMIC/IF_MULTI/IF_PIPELINE macroses with IS_ATOMIC/IS_MULTI/IS_PIPELINE respectively. Remove IF_NOT_* macroses
1 parent 479420f commit 7c5a68c

File tree

3 files changed

+130
-136
lines changed

3 files changed

+130
-136
lines changed

common.h

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -507,12 +507,9 @@ typedef enum _PUBSUB_TYPE {
507507
#define MULTI 1
508508
#define PIPELINE 2
509509

510-
#define IF_ATOMIC() if (redis_sock->mode == ATOMIC)
511-
#define IF_NOT_ATOMIC() if (redis_sock->mode != ATOMIC)
512-
#define IF_MULTI() if (redis_sock->mode & MULTI)
513-
#define IF_NOT_MULTI() if (!(redis_sock->mode & MULTI))
514-
#define IF_PIPELINE() if (redis_sock->mode & PIPELINE)
515-
#define IF_NOT_PIPELINE() if (!(redis_sock->mode & PIPELINE))
510+
#define IS_ATOMIC(redis_sock) (redis_sock->mode == ATOMIC)
511+
#define IS_MULTI(redis_sock) (redis_sock->mode & MULTI)
512+
#define IS_PIPELINE(redis_sock) (redis_sock->mode & PIPELINE)
516513

517514
#define PIPELINE_ENQUEUE_COMMAND(cmd, cmd_len) do { \
518515
if (redis_sock->pipeline_cmd == NULL) { \
@@ -547,15 +544,15 @@ typedef enum _PUBSUB_TYPE {
547544
} while (0)
548545

549546
#define REDIS_PROCESS_REQUEST(redis_sock, cmd, cmd_len) \
550-
IF_PIPELINE() { \
547+
if (IS_PIPELINE(redis_sock)) { \
551548
PIPELINE_ENQUEUE_COMMAND(cmd, cmd_len); \
552549
} else { \
553550
SOCKET_WRITE_COMMAND(redis_sock, cmd, cmd_len); \
554551
} \
555552
efree(cmd);
556553

557554
#define REDIS_PROCESS_RESPONSE_CLOSURE(function, closure_context) \
558-
IF_NOT_PIPELINE() { \
555+
if (!IS_PIPELINE(redis_sock)) { \
559556
if (redis_response_enqueued(redis_sock TSRMLS_CC) != SUCCESS) { \
560557
RETURN_FALSE; \
561558
} \
@@ -583,7 +580,7 @@ typedef enum _PUBSUB_TYPE {
583580
RETURN_FALSE; \
584581
} \
585582
REDIS_PROCESS_REQUEST(redis_sock, cmd, cmd_len); \
586-
IF_ATOMIC() { \
583+
if (IS_ATOMIC(redis_sock)) { \
587584
resp_func(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, NULL, ctx); \
588585
} else { \
589586
REDIS_PROCESS_RESPONSE_CLOSURE(resp_func, ctx) \
@@ -599,7 +596,7 @@ typedef enum _PUBSUB_TYPE {
599596
RETURN_FALSE; \
600597
} \
601598
REDIS_PROCESS_REQUEST(redis_sock, cmd, cmd_len); \
602-
IF_ATOMIC() { \
599+
if (IS_ATOMIC(redis_sock)) { \
603600
resp_func(INTERNAL_FUNCTION_PARAM_PASSTHRU, redis_sock, NULL, ctx); \
604601
} else { \
605602
REDIS_PROCESS_RESPONSE_CLOSURE(resp_func, ctx) \

0 commit comments

Comments
 (0)