Fix false positive in redundant_set_access_control

marcelofabri · marcelofabri · commit dc93d1de82a2 · 2018-05-06T21:42:00.000-07:00
Fixes realm#2182
diff --git a/Rules.md b/Rules.md
@@ -12506,6 +12506,12 @@ public var foo: Int
 var foo: Int
 ```
 
+```swift
+private final class A {
+    private(set) var value: Int
+}
+```
+
 </details>
 <details>
 <summary>Triggering Examples</summary>
@@ -12532,6 +12538,18 @@ open class Foo {
 }
 ```
 
+```swift
+class A {
+    ↓internal(set) var value: Int
+}
+```
+
+```swift
+fileprivate class A {
+    ↓fileprivate(set) var value: Int
+}
+```
+
 </details>
 
 
diff --git a/Source/SwiftLintFramework/Rules/RedundantSetAccessControlRule.swift b/Source/SwiftLintFramework/Rules/RedundantSetAccessControlRule.swift
@@ -17,7 +17,12 @@ public struct RedundantSetAccessControlRule: ASTRule, ConfigurationProviderRule
             "private(set) public var foo: Int",
             "public let foo: Int",
             "public var foo: Int",
-            "var foo: Int"
+            "var foo: Int",
+            """
+            private final class A {
+                private(set) var value: Int
+            }
+            """
         ],
         triggeringExamples: [
             "↓private(set) private var foo: Int",
@@ -28,6 +33,16 @@ public struct RedundantSetAccessControlRule: ASTRule, ConfigurationProviderRule
             open class Foo {
                 ↓open(set) open var bar: Int
             }
+            """,
+            """
+            class A {
+                ↓internal(set) var value: Int
+            }
+            """,
+            """
+            fileprivate class A {
+                ↓fileprivate(set) var value: Int
+            }
             """
         ]
     )
@@ -47,6 +62,22 @@ public struct RedundantSetAccessControlRule: ASTRule, ConfigurationProviderRule
             return []
         }
 
+        let aclAttributes: Set<SwiftDeclarationAttributeKind> = [.private, .fileprivate, .internal, .public, .open]
+        let explicitACL = dictionary.swiftAttributes.first { dict in
+            guard let attribute = dict.attribute.flatMap(SwiftDeclarationAttributeKind.init) else {
+                return false
+            }
+
+            return aclAttributes.contains(attribute)
+        }
+
+        // if it's an inferred `private`, it means the variable is actually inside a fileprivate structure
+        if dictionary.accessibility.flatMap(AccessControlLevel.init(identifier:)) == .private,
+            explicitACL?.offset == nil,
+            dictionary.setterAccessibility.flatMap(AccessControlLevel.init(identifier:)) == .private {
+                return []
+        }
+
         return [
             StyleViolation(ruleDescription: type(of: self).description,
                            severity: configuration.severity,
