disable most eslint-plugin-eslint-plugin rules as they no longer are needed

bradzacher · bradzacher · commit ca5836e6b413 · 2019-02-06T17:11:01.000-08:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -30,7 +30,7 @@
     {
       "files": [
         "packages/eslint-plugin-tslint/tests/**/*.ts",
-        "packages/eslint-plugin/tests/**/*.js",
+        "packages/eslint-plugin/tests/**/*.test.ts",
         "packages/parser/tests/**/*.ts",
         "packages/typescript-estree/tests/**/*.ts"
       ],
@@ -53,22 +53,9 @@
       }
     },
     {
-      "files": ["packages/eslint-plugin/**/*.js"],
+      "files": ["packages/eslint-plugin/test/**/*.ts"],
       "rules": {
-        "eslint-plugin/fixer-return": "error",
-        "eslint-plugin/no-identical-tests": "error",
-        "eslint-plugin/no-missing-placeholders": "error",
-        "eslint-plugin/no-unused-placeholders": "error",
-        "eslint-plugin/no-useless-token-range": "error",
-        "eslint-plugin/require-meta-fixable": "error",
-        "eslint-plugin/prefer-placeholders": "error",
-        "eslint-plugin/prefer-replace-text": "error",
-        "eslint-plugin/no-deprecated-report-api": "error",
-        "eslint-plugin/report-message-format": ["error", "^[A-Z'{].*[\\.}]$"],
-        "eslint-plugin/no-deprecated-context-methods": "error",
-        "eslint-plugin/prefer-output-null": "error",
-        "eslint-plugin/test-case-shorthand-strings": "error",
-        "eslint-plugin/require-meta-type": "error"
+        "eslint-plugin/no-identical-tests": "error"
       }
     }
   ]
diff --git a/packages/eslint-plugin/src/rules/array-type.ts b/packages/eslint-plugin/src/rules/array-type.ts
@@ -4,7 +4,11 @@
  * @author Armano <https://github.com/armano2>
  */
 
-import { TSESTree, AST_NODE_TYPES } from '@typescript-eslint/typescript-estree';
+import {
+  AST_NODE_TYPES,
+  AST_TOKEN_TYPES,
+  TSESTree
+} from '@typescript-eslint/typescript-estree';
 import * as util from '../util';
 
 /**
@@ -124,7 +128,7 @@ export default util.createRule<Options, MessageIds>({
         return false;
       }
 
-      return prevToken.type === AST_NODE_TYPES.Identifier;
+      return prevToken.type === AST_TOKEN_TYPES.Identifier;
     }
 
     /**
diff --git a/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts b/packages/eslint-plugin/src/rules/prefer-namespace-keyword.ts
@@ -4,7 +4,11 @@
  * @author Armano <https://github.com/armano2>
  */
 
-import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/typescript-estree';
+import {
+  AST_NODE_TYPES,
+  AST_TOKEN_TYPES,
+  TSESTree
+} from '@typescript-eslint/typescript-estree';
 import * as util from '../util';
 
 export default util.createRule({
@@ -40,7 +44,7 @@ export default util.createRule({
 
         if (
           moduleType &&
-          moduleType.type === AST_NODE_TYPES.Identifier &&
+          moduleType.type === AST_TOKEN_TYPES.Identifier &&
           moduleType.value === 'module'
         ) {
           context.report({
diff --git a/packages/eslint-plugin/src/util/createRule.ts b/packages/eslint-plugin/src/util/createRule.ts
@@ -24,6 +24,7 @@ type CreateRuleMeta<TMessageIds extends string> = {
 } & RemoveProps<RuleMetaData<TMessageIds>, 'docs'>;
 
 // This function will get much easier to call when this is merged https://github.com/Microsoft/TypeScript/pull/26349
+// TODO - when the above rule lands; add type checking for the context.report `data` property
 export function createRule<
   TOptions extends Readonly<any[]>,
   TMessageIds extends string,
diff --git a/packages/typescript-estree/src/parser.ts b/packages/typescript-estree/src/parser.ts
@@ -418,6 +418,6 @@ export function parseAndGenerateServices<
   };
 }
 
-export { AST_NODE_TYPES } from './ast-node-types';
+export { AST_NODE_TYPES, AST_TOKEN_TYPES } from './ast-node-types';
 export { ParserOptions };
 export { TSESTree };

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`{`
`31`	`31`	`"files": [`
`32`	`32`	`"packages/eslint-plugin-tslint/tests/*/.ts",`
`33`		`- "packages/eslint-plugin/tests/*/.js",`
	`33`	`+ "packages/eslint-plugin/tests/*/.test.ts",`
`34`	`34`	`"packages/parser/tests/*/.ts",`
`35`	`35`	`"packages/typescript-estree/tests/*/.ts"`
`36`	`36`	`],`
`@@ -53,22 +53,9 @@`
`53`	`53`	`}`
`54`	`54`	`},`
`55`	`55`	`{`
`56`		`- "files": ["packages/eslint-plugin/*/.js"],`
	`56`	`+ "files": ["packages/eslint-plugin/test/*/.ts"],`
`57`	`57`	`"rules": {`
`58`		`- "eslint-plugin/fixer-return": "error",`
`59`		`- "eslint-plugin/no-identical-tests": "error",`
`60`		`- "eslint-plugin/no-missing-placeholders": "error",`
`61`		`- "eslint-plugin/no-unused-placeholders": "error",`
`62`		`- "eslint-plugin/no-useless-token-range": "error",`
`63`		`- "eslint-plugin/require-meta-fixable": "error",`
`64`		`- "eslint-plugin/prefer-placeholders": "error",`
`65`		`- "eslint-plugin/prefer-replace-text": "error",`
`66`		`- "eslint-plugin/no-deprecated-report-api": "error",`
`67`		`- "eslint-plugin/report-message-format": ["error", "^[A-Z'{].*[\\.}]$"],`
`68`		`- "eslint-plugin/no-deprecated-context-methods": "error",`
`69`		`- "eslint-plugin/prefer-output-null": "error",`
`70`		`- "eslint-plugin/test-case-shorthand-strings": "error",`
`71`		`- "eslint-plugin/require-meta-type": "error"`
	`58`	`+ "eslint-plugin/no-identical-tests": "error"`
`72`	`59`	`}`
`73`	`60`	`}`
`74`	`61`	`]`
Original file line number	Diff line number	Diff line change
`@@ -418,6 +418,6 @@ export function parseAndGenerateServices<`
`418`	`418`	`};`
`419`	`419`	`}`
`420`	`420`
`421`		`-export { AST_NODE_TYPES } from './ast-node-types';`
	`421`	`+export { AST_NODE_TYPES, AST_TOKEN_TYPES } from './ast-node-types';`
`422`	`422`	`export { ParserOptions };`
`423`	`423`	`export { TSESTree };`