Fix calculating scrollbar handler position

barteksc · barteksc · commit 2c09d9663ffa · 2016-06-08T16:16:14.000+02:00
Fix readme format and add info about ScrollBarPageIndicator
diff --git a/README.md b/README.md
@@ -47,41 +47,41 @@ Use **ScrollBar** class to place scrollbar view near **PDFView**
 
 1. in layout XML (it's important that the parent view is **RelativeLayout**)
 
-``` xml
-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
-	android:layout_width="match_parent"
-	android:layout_height="match_parent">
-
-    <com.github.barteksc.pdfviewer.PDFView
-        android:id="@+id/pdfView"
+    ``` xml
+    <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
         android:layout_width="match_parent"
-        android:layout_height="match_parent"
-		android:layout_toLeftOf="@+id/scrollBar"/>
-
-	<com.github.barteksc.pdfviewer.ScrollBar
-		android:id="@+id/scrollBar"
-		android:layout_width="wrap_content"
-		android:layout_height="match_parent"
-		android:layout_alignParentRight="true"
-		android:layout_alignParentEnd="true" />
-
-</RelativeLayout>
-```
+        android:layout_height="match_parent">
+
+        <com.github.barteksc.pdfviewer.PDFView
+            android:id="@+id/pdfView"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:layout_toLeftOf="@+id/scrollBar"/>
+
+        <com.github.barteksc.pdfviewer.ScrollBar
+            android:id="@+id/scrollBar"
+            android:layout_width="wrap_content"
+            android:layout_height="match_parent"
+            android:layout_alignParentRight="true"
+            android:layout_alignParentEnd="true" />
+
+    </RelativeLayout>
+    ```
 2. in activity or fragment
-``` java
+    ``` java
 
-@Override
-    protected void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
+    @Override
+        protected void onCreate(Bundle savedInstanceState) {
+            super.onCreate(savedInstanceState);
 
-        ...
+            ...
 
-        PDFView pdfView = (PDFView) findViewById(R.id.pdfView);
-        ScrollBar scrollBar = (ScrollBar) findViewById(R.id.scrollBar);
-        pdfView.setScrollBar(scrollBar);
-    }
+            PDFView pdfView = (PDFView) findViewById(R.id.pdfView);
+            ScrollBar scrollBar = (ScrollBar) findViewById(R.id.scrollBar);
+            pdfView.setScrollBar(scrollBar);
+        }
 
-```
+    ```
 
 Scrollbar styling:
 ``` xml
@@ -95,6 +95,9 @@ Scrollbar styling:
         />
 ```
 
+**ScrollBarPageIndicator** is added to scrollbar automatically and is shown while dragging scrollbar handler,
+ displaying number of page on current position.
+
 ## Additional options
 
 ### Bitmap quality
diff --git a/android-pdf-viewer/src/main/java/com/github/barteksc/pdfviewer/ScrollBar.java b/android-pdf-viewer/src/main/java/com/github/barteksc/pdfviewer/ScrollBar.java
@@ -245,6 +245,7 @@ public Parcelable onSaveInstanceState() {
     /** methods for integration with PDFView */
     void addToPDFView(PDFView pdfView) {
         this.pdfView = pdfView;
+        calculateHandlerHeight();
         pageChanged(pdfView.getCurrentPage());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,7 @@ public Parcelable onSaveInstanceState() {`
`245`	`245`	`/** methods for integration with PDFView */`
`246`	`246`	`void addToPDFView(PDFView pdfView) {`
`247`	`247`	`this.pdfView = pdfView;`
	`248`	`+ calculateHandlerHeight();`
`248`	`249`	`pageChanged(pdfView.getCurrentPage());`
`249`	`250`	`}`
`250`	`251`