Fix SQL JOIN in get_last_qsos for station_profile

magicbug · magicbug · commit 5c4c1c2cd5be · 2025-09-09T14:21:21.000+01:00
Changed the SQL query in get_last_qsos to use LEFT JOIN for station_profile instead of JOIN. This ensures that QSOs are returned even if there is no matching station_profile, improving data completeness.
diff --git a/application/models/Logbook_model.php b/application/models/Logbook_model.php
@@ -1932,7 +1932,6 @@ function get_station_id_with_webadif_api()
 
   function get_last_qsos($num, $StationLocationsArray = null)
   {
-
     if ($StationLocationsArray == null) {
       $CI = &get_instance();
       $CI->load->model('logbooks_model');
@@ -1945,13 +1944,13 @@ function get_last_qsos($num, $StationLocationsArray = null)
       $location_list = "'" . implode("','", $logbooks_locations_array) . "'";
 
       $sql = "SELECT * FROM ( select * from " . $this->config->item('table_name') . "
-        WHERE station_id IN(" . $location_list . ")
-        order by col_time_on desc, col_primary_key desc
-        limit " . $num .
+            WHERE station_id IN(" . $location_list . ")
+            order by col_time_on desc, col_primary_key desc
+            limit " . $num .
         ") hrd
-        JOIN station_profile ON station_profile.station_id = hrd.station_id
-        LEFT JOIN dxcc_entities ON hrd.col_dxcc = dxcc_entities.adif
-        order by col_time_on desc, col_primary_key desc";
+            LEFT JOIN station_profile ON station_profile.station_id = hrd.station_id
+            LEFT JOIN dxcc_entities ON hrd.col_dxcc = dxcc_entities.adif
+            order by col_time_on desc, col_primary_key desc";
 
       $query = $this->db->query($sql);
 
