Fix markers legend not being suppressible (#789)

Alexboiboi · web-flow · commit 8b4f17db1c07 · 2024-06-05T08:52:09.000+02:00
* fix markers showlegend

* add test

* pylint
diff --git a/magpylib/_src/display/traces_generic.py b/magpylib/_src/display/traces_generic.py
@@ -63,6 +63,7 @@ def get_trace(self, **kwargs):
             "y": y,
             "z": z,
             "mode": "markers",
+            "showlegend": style.legend.show,  # pylint: disable=no-member
             **marker_kwargs,
             **kwargs,
         }
diff --git a/tests/test_display_plotly.py b/tests/test_display_plotly.py
@@ -383,3 +383,13 @@ def test_legends():
     )
     assert [t.name for t in fig.data] == ["Plotly extra trace (1m|1m|1m)"] * 4
     assert [t.showlegend for t in fig.data] == [True, False, False, False]
+
+    fig = magpy.show(
+        markers=[(0, 0, 0)],
+        backend="plotly",
+        style_legend_show=False,
+        return_fig=True,
+    )
+
+    assert [t.name for t in fig.data] == ["Marker"]
+    assert [t.showlegend for t in fig.data] == [False]

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ def get_trace(self, **kwargs):`
`63`	`63`	`"y": y,`
`64`	`64`	`"z": z,`
`65`	`65`	`"mode": "markers",`
	`66`	`+ "showlegend": style.legend.show, # pylint: disable=no-member`
`66`	`67`	`**marker_kwargs,`
`67`	`68`	`**kwargs,`
`68`	`69`	`}`