-
Notifications
You must be signed in to change notification settings - Fork 60
Description
We mix up the parameters radius
(e.g. CylinderSegment
) and diameter
(e.g. in Cylinder
) in different classes. The original thought was to stick to diameter
as it corresponds best to "sidelength", but that philosophy was broken with CylinderSegment
.
Which one is preferable depends on case to case, and on taste. I had multiple experiences where i would have preferred radius over diameter.
So why not use both?
Lets implement a radius
parameter that will automatically set diameter
and vice versa, like we did it with magnetization
and polarization
.
This ofc works only on oo and functional levels. Core stays as it is. Since we decided to keep positionals radius
should then be at the "end" messing up our new "argument order" (position - dimension - excitation) but thats not so critical I think.
This feels like a real benefit to me. What do you think?