Fix Str::endsWith() with needles that start with space and numbers.

Loduis Madariaga · Loduis Madariaga · commit a70c74d68c9b · 2014-08-01T18:27:27.000-05:00
diff --git a/src/Illuminate/Support/Str.php b/src/Illuminate/Support/Str.php
@@ -56,7 +56,7 @@ public static function endsWith($haystack, $needles)
 	{
 		foreach ((array) $needles as $needle)
 		{
-			if ($needle == substr($haystack, -strlen($needle))) return true;
+			if ((string) $needle === substr($haystack, -strlen($needle))) return true;
 		}
 
 		return false;
diff --git a/tests/Support/SupportStrTest.php b/tests/Support/SupportStrTest.php
@@ -58,6 +58,7 @@ public function testEndsWith()
 		$this->assertFalse(Str::endsWith('jason', 'no'));
 		$this->assertFalse(Str::endsWith('jason', array('no')));
 		$this->assertFalse(Str::endsWith('jason', ''));
+		$this->assertFalse(Str::endsWith('7', ' 7'));
 	}
 
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public static function endsWith($haystack, $needles)`
`56`	`56`	`{`
`57`	`57`	`foreach ((array) $needles as $needle)`
`58`	`58`	`{`
`59`		`- if ($needle == substr($haystack, -strlen($needle))) return true;`
	`59`	`+ if ((string) $needle === substr($haystack, -strlen($needle))) return true;`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ public function testEndsWith()`
`58`	`58`	`$this->assertFalse(Str::endsWith('jason', 'no'));`
`59`	`59`	`$this->assertFalse(Str::endsWith('jason', array('no')));`
`60`	`60`	`$this->assertFalse(Str::endsWith('jason', ''));`
	`61`	`+ $this->assertFalse(Str::endsWith('7', ' 7'));`
`61`	`62`	`}`
`62`	`63`
`63`	`64`