enforce asynchronous runTest call in event thread

PhilippSalvisberg · PhilippSalvisberg · commit a008c3643617 · 2018-01-26T10:33:48.000+01:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend b/sqldev/src/main/java/org/utplsql/sqldev/UtplsqlWorksheet.xtend
@@ -76,7 +76,7 @@ class UtplsqlWorksheet {
 		}
 	}
 
-	def runTest() {
+	private def runTest() {
 		val worksheet = openWorksheet
 		worksheet.runScript
 		logger.fine('''utPLSQL test called for «path» in «connectionName».''')
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/editor/menu/UtplsqlEditorController.xtend b/sqldev/src/main/java/org/utplsql/sqldev/editor/menu/UtplsqlEditorController.xtend
@@ -34,10 +34,7 @@ class UtplsqlEditorController implements Controller {
 
 	override handleEvent(IdeAction action, Context context) {
 		if (action.commandId === UTLPLSQL_EDITOR_TEST_CMD_ID) {
-			val Runnable runnable = [|runTest(context)]
-			val thread = new Thread(runnable)
-			thread.name = "utPLSQL run test"
-			thread.start
+			runTest(context)
 			return true
 		}
 		return false
@@ -78,7 +75,7 @@ class UtplsqlEditorController implements Controller {
 					connectionName = view.connectionName
 				}
 				val utPlsqlWorksheet = new UtplsqlWorksheet(path, connectionName)
-				utPlsqlWorksheet.runTest
+				utPlsqlWorksheet.runTestAsync
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ class UtplsqlWorksheet {`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`
`79`		`- def runTest() {`
	`79`	`+ private def runTest() {`
`80`	`80`	`val worksheet = openWorksheet`
`81`	`81`	`worksheet.runScript`
`82`	`82`	`logger.fine('''utPLSQL test called for «path» in «connectionName».''')`
Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,7 @@ class UtplsqlEditorController implements Controller {`
`34`	`34`
`35`	`35`	`override handleEvent(IdeAction action, Context context) {`
`36`	`36`	`if (action.commandId === UTLPLSQL_EDITOR_TEST_CMD_ID) {`
`37`		`- val Runnable runnable = [\|runTest(context)]`
`38`		`- val thread = new Thread(runnable)`
`39`		`- thread.name = "utPLSQL run test"`
`40`		`- thread.start`
	`37`	`+ runTest(context)`
`41`	`38`	`return true`
`42`	`39`	`}`
`43`	`40`	`return false`
`@@ -78,7 +75,7 @@ class UtplsqlEditorController implements Controller {`
`78`	`75`	`connectionName = view.connectionName`
`79`	`76`	`}`
`80`	`77`	`val utPlsqlWorksheet = new UtplsqlWorksheet(path, connectionName)`
`81`		`- utPlsqlWorksheet.runTest`
	`78`	`+ utPlsqlWorksheet.runTestAsync`
`82`	`79`	`}`
`83`	`80`	`}`
`84`	`81`	`}`