Don't use unstable sorting in similarity measures #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-huber
approved these changes
Jun 24, 2024
Collaborator
florian-huber
left a comment
There was a problem hiding this comment.
Thanks @tornikeo!
Looks good to me and will be merged.
(and sorry, took me a while...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #596 , ModifiedCosine and other classes also use non-stable version of
np.argsort. I've encountered this issue once more while implementing CudaModifiedCosine.In this PR, I've changed sorting kind to
mergesortfor other similarity measures too, since this issue is likely to pop up once I've added those too.