Conversion Node implementation of 'nu' #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Jun 6, 2023
examples/subsample.py
Outdated
| @@ -68,7 +68,7 @@ def query( | |||
| sub = Subsample() | |||
| cmap = mpl.colormaps["coolwarm"] | |||
| norm = Normalize(-2.2, 2.2) | |||
| im = ImageWrapper(sub, {"image": lambda image: cmap(norm(image))}) | |||
| im = ImageWrapper(sub) | |||
There was a problem hiding this comment.
fixed, the ImageWrapper class takes cmap/norm as inputs, such that you do not need to manually do the func colormapping lambda, just neglected to pass those in in this example.
(It worked by some definition of "work", just with viridis so the cmap/norm setup here was not used, updated now it uses those, just with nicer API for the common need of ImageWrapper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26 (More detailed thoughts)
Supersedes/Closes #17 (the original PR that inspired some of the thoughts)