Inline AnchoredOffsetBox._update_offset_func.

anntzer · anntzer · commit 00b5604a346d · 2021-11-21T15:40:27.000+01:00
It is only called in `get_window_extent` -- and in `draw`, but *that*
call is immediately followed by a call to `get_window_extent`, so it is
redundant.
diff --git a/lib/matplotlib/offsetbox.py b/lib/matplotlib/offsetbox.py
@@ -1044,27 +1044,19 @@ def set_bbox_to_anchor(self, bbox, transform=None):
 
     def get_window_extent(self, renderer):
         # docstring inherited
-        self._update_offset_func(renderer)
-        return super().get_window_extent(renderer)
-
-    def _update_offset_func(self, renderer, fontsize=None):
-        """
-        Update the offset func which depends on the dpi of the
-        renderer (because of the padding).
-        """
-        if fontsize is None:
-            fontsize = renderer.points_to_pixels(
-                self.prop.get_size_in_points())
+        # Update the offset func, which depends on the dpi of the renderer
+        # (because of the padding).
+        fontsize = renderer.points_to_pixels(self.prop.get_size_in_points())
 
         def _offset(w, h, xd, yd, renderer):
             bbox = Bbox.from_bounds(0, 0, w, h)
-            borderpad = self.borderpad * fontsize
+            pad = self.borderpad * fontsize
             bbox_to_anchor = self.get_bbox_to_anchor()
-            x0, y0 = _get_anchored_bbox(
-                self.loc, bbox, bbox_to_anchor, borderpad)
+            x0, y0 = _get_anchored_bbox(self.loc, bbox, bbox_to_anchor, pad)
             return x0 + xd, y0 + yd
 
         self.set_offset(_offset)
+        return super().get_window_extent(renderer)
 
     def update_frame(self, bbox, fontsize=None):
         self.patch.set_bounds(bbox.bounds)
@@ -1076,11 +1068,9 @@ def draw(self, renderer):
         if not self.get_visible():
             return
 
-        fontsize = renderer.points_to_pixels(self.prop.get_size_in_points())
-        self._update_offset_func(renderer, fontsize)
-
         # update the location and size of the legend
         bbox = self.get_window_extent(renderer)
+        fontsize = renderer.points_to_pixels(self.prop.get_size_in_points())
         self.update_frame(bbox, fontsize)
         self.patch.draw(renderer)
 
diff --git a/lib/mpl_toolkits/axes_grid1/inset_locator.py b/lib/mpl_toolkits/axes_grid1/inset_locator.py
@@ -70,18 +70,11 @@ def draw(self, renderer):
 
     def __call__(self, ax, renderer):
         self.axes = ax
-
-        fontsize = renderer.points_to_pixels(self.prop.get_size_in_points())
-        self._update_offset_func(renderer, fontsize)
-
-        width, height, xdescent, ydescent = self.get_extent(renderer)
-
-        px, py = self.get_offset(width, height, 0, 0, renderer)
-        bbox_canvas = Bbox.from_bounds(px, py, width, height)
+        bbox = self.get_window_extent(renderer)
+        px, py = self.get_offset(bbox.width, bbox.height, 0, 0, renderer)
+        bbox_canvas = Bbox.from_bounds(px, py, bbox.width, bbox.height)
         tr = ax.figure.transFigure.inverted()
-        bb = TransformedBbox(bbox_canvas, tr)
-
-        return bb
+        return TransformedBbox(bbox_canvas, tr)
 
 
 class AnchoredSizeLocator(AnchoredLocatorBase):
