spines: default transform is in data units, add set_bounds() call

astraw · astraw · commit 00cfd281f03e · 2009-12-21T00:46:59.000Z
svn path=/trunk/matplotlib/; revision=8044
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,6 @@
+2009-12-20 spines: put spines in data coordinates, add set_bounds()
+           call. -ADS
+
 2009-12-18 Don't limit notch size in boxplot to q1-q3 range, as this
            is effectively making the data look better than it is. - ADS
 
diff --git a/lib/matplotlib/axes.py b/lib/matplotlib/axes.py
@@ -2065,6 +2065,9 @@ def set_xlim(self, xmin=None, xmax=None, emit=True, **kwargs):
                         other.figure.canvas is not None):
                         other.figure.canvas.draw_idle()
 
+        for loc in ('bottom','top'):
+            self.spines[loc].set_bounds(xmin,xmax)
+
         return xmin, xmax
 
     def get_xscale(self):
@@ -2238,6 +2241,10 @@ def set_ylim(self, ymin=None, ymax=None, emit=True, **kwargs):
                     if (other.figure != self.figure and
                         other.figure.canvas is not None):
                         other.figure.canvas.draw_idle()
+
+        for loc in ('left','right'):
+            self.spines[loc].set_bounds(ymin,ymax)
+
         return ymin, ymax
 
     def get_yscale(self):
diff --git a/lib/matplotlib/spines.py b/lib/matplotlib/spines.py
@@ -55,7 +55,7 @@ def __init__(self,axes,spine_type,path,**kwargs):
         self.axis = None
 
         self.set_zorder(2.5)
-        self.set_transform(self.axes.transAxes) # default transform
+        self.set_transform(self.axes.transData) # default transform
 
         # Defer initial position determination. (Not much support for
         # non-rectangular axes is currently implemented, and this lets
@@ -82,6 +82,7 @@ def set_patch_circle(self,center,radius):
         self._width = radius*2
         self._height = radius*2
         self._angle = 0
+        self.set_transform(self.axes.transAxes) # circle drawn on axes transform
 
     def set_patch_line(self):
         """set the spine to be linear"""
@@ -229,9 +230,9 @@ def set_position(self,position):
         t = self.get_spine_transform()
         if self.spine_type in ['left','right']:
             t2 = mtransforms.blended_transform_factory(t,
-                                                       self.axes.transAxes)
+                                                       self.axes.transData)
         elif self.spine_type in ['bottom','top']:
-            t2 = mtransforms.blended_transform_factory(self.axes.transAxes,
+            t2 = mtransforms.blended_transform_factory(self.axes.transData,
                                                        t)
         self.set_transform(t2)
 
@@ -278,6 +279,19 @@ def get_spine_transform(self):
         else:
             raise ValueError("unknown spine_transform type: %s"%what)
 
+    def set_bounds( self, low, high ):
+        v1 = self._path.vertices[:] # copy
+        assert v1.shape == (2,2), 'unexpected vertices shape'
+        if self.spine_type in ['left','right']:
+            v1[0,1] = low
+            v1[1,1] = high
+        elif self.spine_type in ['bottom','top']:
+            v1[0,0] = low
+            v1[1,0] = high
+        else:
+            raise ValueError('unable to set bounds for spine "%s"'%spine_type)
+        self._path.vertices = v1 # replace
+
     @classmethod
     def linear_spine(cls, axes, spine_type, **kwargs):
         """
