FIX: fix the positional arguments

jklymak · jklymak · commit 020acb6a49d6 · 2022-12-12T10:54:42.000-08:00
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1113,22 +1113,25 @@ def legend(self, *args, **kwargs):
             # extra_args = extra_args[1:]
             pass
         transform = kwargs.pop('bbox_transform', self.transSubfigure)
-        loc = kwargs.pop('loc', None)
-        # handle outside legends:
-        outside = None
-        if isinstance(loc, str):
-            if loc.split()[0] == 'outside':
-                loc = loc.replace('outside ', '')
-                outside = loc.replace('center ', '')
-                outside = outside.split()[0]
-                locs = loc.split()
-                if len(locs) > 1 and locs[0] in ('right', 'left'):
-                    # locs doesn't accept "left upper", etc, so swap
-                    if locs[0] != 'center':
-                        locs = locs[::-1]
-                    loc = locs[0] + ' ' + locs[1]
-
-        kwargs['loc'] = loc
+        if 'loc' in kwargs:
+            # need to protect this in case loc was passed in
+            # positionally...
+            loc = kwargs.pop('loc', None)
+            # handle outside legends:
+            outside = None
+            if isinstance(loc, str):
+                if loc.split()[0] == 'outside':
+                    loc = loc.replace('outside ', '')
+                    outside = loc.replace('center ', '')
+                    outside = outside.split()[0]
+                    locs = loc.split()
+                    if len(locs) > 1 and locs[0] in ('right', 'left'):
+                        # locs doesn't accept "left upper", etc, so swap
+                        if locs[0] != 'center':
+                            locs = locs[::-1]
+                        loc = locs[0] + ' ' + locs[1]
+
+            kwargs['loc'] = loc
         # explicitly set the bbox transform if the user hasn't.
         l = mlegend.Legend(self, handles, labels, *extra_args,
                            bbox_transform=transform, **kwargs)
