API: un-deprecate keyword only args to set_xlim, set_ylim

tacaswell · tacaswell · commit 02ef76926df3 · 2019-02-12T23:02:48.000-05:00
These were originally documented and deprecated in #11137 however in later discussion we learned: - the 'left, right' / 'top, bottom' names don't make sense in the context of non-rectangular plots - we have at least one frustrated user The original names were `xmin, xmax` but were changed to `left, right` in 9ca5db0 (pre 1.0) and the kwarg popping was added for back-compatibility.
diff --git a/doc/api/api_changes.rst b/doc/api/api_changes.rst
@@ -154,8 +154,9 @@ Different exception types for undocumented options
   and ``right`` arguments.  :meth:`~matplotlib.axes.Axes.set_ylim` and the
   3D equivalents (e.g. :meth:`~mpl_toolkits.axes.Axes3D.set_zlim3d`) had a
   corresponding problem.
-  The ``_min`` and ``_max`` arguments are now deprecated, and a ``TypeError``
-  will be raised if they would override the earlier limit arguments.
+  A ``TypeError`` will be raised if they would override the earlier
+  limit arguments.  In 3.0 these were kwargs were deprecated, but in 3.1
+  the deprecation was undone.
 
 
 Improved call signature for ``Axes.margins``
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -3145,8 +3145,7 @@ def set_xlim(self, left=None, right=None, emit=True, auto=False,
             False turns off (default action), None leaves unchanged.
 
         xmin, xmax : scalar, optional
-            These arguments are deprecated and will be removed in a future
-            version.  They are equivalent to left and right respectively,
+            They are equivalent to left and right respectively,
             and it is an error to pass both *xmin* and *left* or
             *xmax* and *right*.
 
@@ -3188,14 +3187,10 @@ def set_xlim(self, left=None, right=None, emit=True, auto=False,
         if right is None and np.iterable(left):
             left, right = left
         if xmin is not None:
-            cbook.warn_deprecated('3.0', name='`xmin`',
-                                  alternative='`left`', obj_type='argument')
             if left is not None:
                 raise TypeError('Cannot pass both `xmin` and `left`')
             left = xmin
         if xmax is not None:
-            cbook.warn_deprecated('3.0', name='`xmax`',
-                                  alternative='`right`', obj_type='argument')
             if right is not None:
                 raise TypeError('Cannot pass both `xmax` and `right`')
             right = xmax
@@ -3529,8 +3524,7 @@ def set_ylim(self, bottom=None, top=None, emit=True, auto=False,
             *False* turns off (default action), *None* leaves unchanged.
 
         ymin, ymax : scalar, optional
-            These arguments are deprecated and will be removed in a future
-            version.  They are equivalent to bottom and top respectively,
+            They are equivalent to bottom and top respectively,
             and it is an error to pass both *ymin* and *bottom* or
             *ymax* and *top*.
 
@@ -3571,14 +3565,10 @@ def set_ylim(self, bottom=None, top=None, emit=True, auto=False,
         if top is None and np.iterable(bottom):
             bottom, top = bottom
         if ymin is not None:
-            cbook.warn_deprecated('3.0', name='`ymin`',
-                                  alternative='`bottom`', obj_type='argument')
             if bottom is not None:
                 raise TypeError('Cannot pass both `ymin` and `bottom`')
             bottom = ymin
         if ymax is not None:
-            cbook.warn_deprecated('3.0', name='`ymax`',
-                                  alternative='`top`', obj_type='argument')
             if top is not None:
                 raise TypeError('Cannot pass both `ymax` and `top`')
             top = ymax
